Source/core/editing/DeleteSelectionCommand.cpp - Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/DeleteSelectionCommand.cpp

Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/execCommand/delete-hidden-crash.html ('K') | « LayoutTests/editing/execCommand/delete-hidden-crash-expected.txt ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | Source/core/editing/htmlediting.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/DeleteSelectionCommand.cpp

diff --git a/Source/core/editing/DeleteSelectionCommand.cpp b/Source/core/editing/DeleteSelectionCommand.cpp

index d7f5f19cfe247d04db5066ccc4d2a47d8c562e05..019429b337b019f8c99ffa10dff0e7911e47f957 100644

--- a/Source/core/editing/DeleteSelectionCommand.cpp

+++ b/Source/core/editing/DeleteSelectionCommand.cpp

@@ -166,7 +166,7 @@ void DeleteSelectionCommand::initializePositionData()

ASSERT(isEditablePosition(start, ContentIsEditable, DoNotUpdateStyle));

if (!isEditablePosition(end, ContentIsEditable, DoNotUpdateStyle))

- end = lastEditablePositionBeforePositionInRoot(end, highestEditableRoot(start)).deepEquivalent();

+ end = lastEditablePositionBeforePositionInRoot(end, highestEditableRoot(start));

m_upstreamStart = start.upstream();

m_downstreamStart = start.downstream();