Use TestBrowserThreadBundle instead of TestBrowserThread in sync code.

Use TestBrowserThreadBundle instead of TestBrowserThread in sync code.

Replacing use of TestBrowserThread because it is deprecated and harder
to use correctly.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278285

[maniscalco, 2014-06-18 16:14:45]

Nicolas, would you please review this cleanup change.

[Nicolas Zea, 2014-06-18 20:49:00]

lgtm

[maniscalco, 2014-06-18 20:56:48]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-06-18 20:58:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/340643002/40001

[commit-bot: I haz the power, 2014-06-19 06:39:54]

Change committed as 278285

[Nico, 2014-06-25 01:11:18]

Cool!

However, it looks like the drmemory bot having an issue with this:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

Can you take a look?

{
UNADDRESSABLE ACCESS
name=<insert_a_suppression_name_here>
*!std::_Tree<>::_Eqrange
*!testing::Mock::UnregisterLocked
*!testing::internal::FunctionMockerBase<>::~FunctionMockerBase<>
*!browser_sync::ChangeProcessorMock::~ChangeProcessorMock
*!browser_sync::ChangeProcessorMock::`scalar deleting destructor'
*!browser_sync::NonFrontendDataTypeController::BackendComponentsContainer::~BackendComponentsContainer
*!browser_sync::DestroyComponentsInBackend
*!base::internal::Invoker<>::Run
base.dll!base::MessageLoop::RunTask
base.dll!base::MessageLoop::DeferOrRunPendingTask
base.dll!base::MessageLoop::DoWork
base.dll!base::MessagePumpDefault::Run
base.dll!base::MessageLoop::RunHandler
base.dll!base::Thread::Run
content.dll!content::BrowserThreadImpl::DBThreadRun
content.dll!content::BrowserThreadImpl::Run
base.dll!base::Thread::ThreadMain
base.dll!base::`anonymous namespace'::ThreadFunc
KERNEL32.dll!BaseThreadInitThunk
}

[maniscalco, 2014-06-25 20:31:26]

Thanks for pointing that out.  zhaoqin@ mentioned the same thing (crbug/387387).
 It's not clear to me why this caused problems for the drmemory bot.

I've been unable to repro on linux with valgrind/asan/tsan.  I did a partial
revert (r279603) to get things green.


On 2014/06/25 01:11:18, Nico (away) wrote:
> Cool!
> 
> However, it looks like the drmemory bot having an issue with this:
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...
> 
> Can you take a look?
> 
> {
> UNADDRESSABLE ACCESS
> name=<insert_a_suppression_name_here>
> *!std::_Tree<>::_Eqrange
> *!testing::Mock::UnregisterLocked
> *!testing::internal::FunctionMockerBase<>::~FunctionMockerBase<>
> *!browser_sync::ChangeProcessorMock::~ChangeProcessorMock
> *!browser_sync::ChangeProcessorMock::`scalar deleting destructor'
>
*!browser_sync::NonFrontendDataTypeController::BackendComponentsContainer::~BackendComponentsContainer
> *!browser_sync::DestroyComponentsInBackend
> *!base::internal::Invoker<>::Run
> base.dll!base::MessageLoop::RunTask
> base.dll!base::MessageLoop::DeferOrRunPendingTask
> base.dll!base::MessageLoop::DoWork
> base.dll!base::MessagePumpDefault::Run
> base.dll!base::MessageLoop::RunHandler
> base.dll!base::Thread::Run
> content.dll!content::BrowserThreadImpl::DBThreadRun
> content.dll!content::BrowserThreadImpl::Run
> base.dll!base::Thread::ThreadMain
> base.dll!base::`anonymous namespace'::ThreadFunc
> KERNEL32.dll!BaseThreadInitThunk
> }