Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

Issue 340643002: Use TestBrowserThreadBundle instead of TestBrowserThread in sync code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/typed_url_model_associator_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
index 8b4f85e1725808ed2a1ec7eaf00430983005e06b..02195bea7fd54c199fbaf09fc7377a1f24d6e3d3 100644
--- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
@@ -34,7 +34,7 @@
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/sync_driver/data_type_error_handler.h"
#include "components/sync_driver/data_type_error_handler_mock.h"
-#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "sync/api/sync_error.h"
#include "sync/internal_api/public/change_record.h"
#include "sync/internal_api/public/read_node.h"
@@ -49,7 +49,6 @@
namespace browser_sync {
-using content::BrowserThread;
using syncer::BaseNode;
using testing::_;
using testing::InvokeWithoutArgs;
@@ -320,11 +319,9 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
ProfileSyncServiceBookmarkTest()
: model_(NULL),
- ui_thread_(BrowserThread::UI, &message_loop_),
- file_thread_(BrowserThread::FILE, &message_loop_),
+ thread_bundle_(content::TestBrowserThreadBundle::DEFAULT),
local_merge_result_(syncer::BOOKMARKS),
- syncer_merge_result_(syncer::BOOKMARKS) {
- }
+ syncer_merge_result_(syncer::BOOKMARKS) {}
virtual ~ProfileSyncServiceBookmarkTest() {
StopSync();
@@ -403,7 +400,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
// This noticeably speeds up the unit tests that request it.
if (save == DONT_SAVE_TO_STORAGE)
model_->ClearStore();
- message_loop_.RunUntilIdle();
+ base::MessageLoop::current()->RunUntilIdle();
}
int GetSyncBookmarkCount() {
@@ -542,7 +539,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
}
model_associator_.reset();
- message_loop_.RunUntilIdle();
+ base::MessageLoop::current()->RunUntilIdle();
// TODO(akalin): Actually close the database and flush it to disk
// (and make StartSync reload from disk). This would require
@@ -552,7 +549,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
void UnloadBookmarkModel() {
profile_.CreateBookmarkModel(false /* delete_bookmarks */);
model_ = NULL;
- message_loop_.RunUntilIdle();
+ base::MessageLoop::current()->RunUntilIdle();
}
bool InitSyncNodeFromChromeNode(const BookmarkNode* bnode,
@@ -741,12 +738,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
scoped_ptr<BookmarkModelAssociator> model_associator_;
private:
- // Used by both |ui_thread_| and |file_thread_|.
- base::MessageLoop message_loop_;
- content::TestBrowserThread ui_thread_;
- // Needed by |model_|.
- content::TestBrowserThread file_thread_;
-
+ content::TestBrowserThreadBundle thread_bundle_;
syncer::SyncMergeResult local_merge_result_;
syncer::SyncMergeResult syncer_merge_result_;
};
« no previous file with comments | « chrome/browser/sync/glue/typed_url_model_associator_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698