android: Fix snapshot height by including toolbar offset

android: Fix snapshot height by including toolbar offset

The Android snapshot was found to be chopping off the bottom content.  This is
due to not accounting for the height of the toolbar.  This patch enlarges the
snapshot by that offset.

BUG=384551
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278843

[powei, 2014-06-17 20:08:42]

Ptal.  Thanks.

[Ted C, 2014-06-17 20:10:48]

lgtm

[aelias_OOO_until_Jul13, 2014-06-17 21:11:20]

lgtm

[powei, 2014-06-19 22:17:07]

Changed patch to read only content and not toolbar.

+skyostil to make sure it's ok to remove the offset added for the old readback
path

+kbr for the pixel test rebaseline.  The gpu tests are failing due to missing
reference image.  Do I need to something else to rebaseline?


Thanks

[Ken Russell (switch to Gerrit), 2014-06-19 22:37:27]

On 2014/06/19 22:17:07, powei wrote:
> +kbr for the pixel test rebaseline.  The gpu tests are failing due to missing
> reference image.  Do I need to something else to rebaseline?

It's necessary to land two CLs to update these reference images. In this CL,
mark the tests as failing; then submit a follow-on CL through the commit queue
which removes the failure expectations. Please see
http://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Addin...
.

[Ken Russell (switch to Gerrit), 2014-06-19 22:37:58]

LGTM if the failure expectations are added and this goes through the CQ cleanly.

[powei, 2014-06-19 23:17:23]

On 2014/06/19 22:37:27, Ken Russell wrote:
> On 2014/06/19 22:17:07, powei wrote:
> > +kbr for the pixel test rebaseline.  The gpu tests are failing due to
missing
> > reference image.  Do I need to something else to rebaseline?
> 
> It's necessary to land two CLs to update these reference images. In this CL,
> mark the tests as failing; then submit a follow-on CL through the commit queue
> which removes the failure expectations. Please see
>
http://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Addin...
> .

Done. Will have a follow up to remove the failure expectation.

[Sami, 2014-06-20 00:20:10]

lgtm as long as this means the screenshot doesn't contain the toolbar *both* in
Chrome and content shell. Please verify both cases.

[powei, 2014-06-20 17:49:44]

On 2014/06/20 00:20:10, Sami wrote:
> lgtm as long as this means the screenshot doesn't contain the toolbar *both*
in
> Chrome and content shell. Please verify both cases.

verified.

[powei, 2014-06-20 17:49:49]

The CQ bit was checked by powei@chromium.org

[commit-bot: I haz the power, 2014-06-20 17:54:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/powei@chromium.org/340603002/60001

[commit-bot: I haz the power, 2014-06-20 22:06:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-20 22:37:17]

Change committed as 278843