content/browser/android/content_view_core_impl.cc - Issue 340603002: android: Fix snapshot height by including toolbar offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 340603002: android: Fix snapshot height by including toolbar offset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set pixel test expect to fail Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 2335d0a5fb05b9ca4df9420b4bb70bf60b3a5609..aed766bf31e3cf38cdc80d40c429d2569dc79abc 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -393,11 +393,8 @@ void ContentViewCoreImpl::UpdateFrameInfo(

return;

if (window_android_) {

- gfx::Vector2dF window_offset(

- Java_ContentViewCore_getLocationInWindowX(env, obj.obj()),

- Java_ContentViewCore_getLocationInWindowY(env, obj.obj()));

window_android_->set_content_offset(

- gfx::ScaleVector2d(content_offset, dpi_scale_) + window_offset);

+ gfx::ScaleVector2d(content_offset, dpi_scale_));

}

Java_ContentViewCore_updateFrameInfo(

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContentView.java » ('j') | no next file with comments »