Issue 340553002: Mojo validation test input parser: disallow multiple [anchr]s with the same ID.

Issue 340553002: Mojo validation test input parser: disallow multiple [anchr]s with the same ID. (Closed)

Created:
6 years, 6 months ago by yzshen1

Modified:
6 years, 6 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo validation test input parser: disallow multiple [anchr]s with the same ID. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277905

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	mojo/public/cpp/bindings/tests/validation_test_input_parser.cc	View		3 chunks	+6 lines, -0 lines	4 comments	Download
	M	mojo/public/cpp/bindings/tests/validation_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

lgtm https://codereview.chromium.org/340553002/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc File mojo/public/cpp/bindings/tests/validation_test_input_parser.cc (right): https://codereview.chromium.org/340553002/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc#newcode335 mojo/public/cpp/bindings/tests/validation_test_input_parser.cc:335: return false; do we want to set *error_message_ ...

6 years, 6 months ago (2014-06-17 17:38:33 UTC) #2

yzshen1

https://codereview.chromium.org/340553002/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc File mojo/public/cpp/bindings/tests/validation_test_input_parser.cc (right): https://codereview.chromium.org/340553002/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc#newcode335 mojo/public/cpp/bindings/tests/validation_test_input_parser.cc:335: return false; On 2014/06/17 17:38:33, Tom Sepez wrote: > ...

6 years, 6 months ago (2014-06-17 17:41:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/340553002/1

6 years, 6 months ago (2014-06-17 19:40:15 UTC) #6

Message was sent while issue was closed.

Change committed as 277905

Expand Messages | Collapse Messages