Mojo validation test input parser: disallow multiple [anchr]s with the same ID.

mojo/public/cpp/bindings/tests/validation_test_input_parser.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/tests/validation_test_input_parser.h"
 
 #include <assert.h>
 #include <stdio.h>
 #include <string.h>
 
 #include <limits>
 #include <map>
+#include <set>
 #include <utility>
 
 #include "mojo/public/c/system/macros.h"
 
 namespace mojo {
 namespace test {
 namespace {
 
 class ValidationTestInputParser {
  public:
@@ skipping 82 matching lines @@
   static const size_t kDataTypeCount;
 
   const std::string& input_;
   size_t input_cursor_;
 
   std::vector<uint8_t>* data_;
   size_t* num_handles_;
   std::string* error_message_;
 
   std::map<std::string, PendingDistanceItem> pending_distance_items_;
+  std::set<std::string> anchors_;
 };
 
 #define DATA_TYPE(name, data_size, parse_data_func) \
     {name, sizeof(name) - 1, data_size, parse_data_func}
 
 const ValidationTestInputParser::DataType
     ValidationTestInputParser::kDataTypes[] = {
   DATA_TYPE("[u1]", 1, &ValidationTestInputParser::ParseUnsignedInteger),
   DATA_TYPE("[u2]", 2, &ValidationTestInputParser::ParseUnsignedInteger),
   DATA_TYPE("[u4]", 4, &ValidationTestInputParser::ParseUnsignedInteger),
@@ skipping 197 matching lines @@
 
   PendingDistanceItem item = {data_->size(), type.data_size};
   data_->resize(data_->size() + type.data_size);
   pending_distance_items_[value_string] = item;
 
   return true;
 }
 
 bool ValidationTestInputParser::ParseAnchor(const DataType& type,
                                             const std::string& value_string) {
+  if (anchors_.find(value_string) != anchors_.end())
+    return false;

[Tom Sepez, 2014/06/17 17:38:33]

do we want to set *error_message_ here?

[yzshen1, 2014/06/17 17:41:24]

It will be the general error "Error occurred when parsing [anchr]xxxx". (Set at
line 173.)

I think that is okay. What do you think?

+  anchors_.insert(value_string);
+
   std::map<std::string, PendingDistanceItem>::iterator iter =
       pending_distance_items_.find(value_string);
   if (iter == pending_distance_items_.end())
     return false;
 
   PendingDistanceItem dist_item = iter->second;
   pending_distance_items_.erase(iter);
 
   size_t distance = data_->size() - dist_item.pos;
   switch (dist_item.data_size) {
     case 4:
       return ConvertAndFillData<uint32_t>(dist_item.pos, distance);
     case 8:

[Tom Sepez, 2014/06/17 17:38:33]

similarly, should these also set error_message_ ?

[yzshen1, 2014/06/17 17:41:23]

They all return the message I mentioned above. 

       return ConvertAndFillData<uint64_t>(dist_item.pos, distance);
     default:
       assert(false);
       return false;
   }
 }
 
 bool ValidationTestInputParser::ParseHandles(const DataType& type,
                                              const std::string& value_string) {
   // It should be the first item.
@@ skipping 36 matching lines @@
 bool ParseValidationTestInput(const std::string& input,
                               std::vector<uint8_t>* data,
                               size_t* num_handles,
                               std::string* error_message) {
   ValidationTestInputParser parser(input, data, num_handles, error_message);
   return parser.Run();
 }
 
 }  // namespace test
 }  // namespace mojo