Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340543002: Enable gallery watches on Mac (Closed)

Created:
6 years, 6 months ago by vandebo (ex-Chrome)
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, extensions-reviews_chromium.org, vandebo (ex-Chrome), Lei Zhang, tommycli, Greg Billock, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Make tests pass if recursive watch not supported #

Total comments: 4

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -260 lines) Patch
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 9 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 1 2 5 chunks +145 lines, -236 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries_private/gallerywatch/test.js View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vandebo (ex-Chrome)
6 years, 6 months ago (2014-06-17 16:57:23 UTC) #1
Lei Zhang
https://codereview.chromium.org/340543002/diff/20001/chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc File chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc (right): https://codereview.chromium.org/340543002/diff/20001/chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc#newcode124 chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc:124: // Returns true if successful. return type isn't bool? ...
6 years, 6 months ago (2014-06-17 18:20:23 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/340543002/diff/20001/chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc File chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc (right): https://codereview.chromium.org/340543002/diff/20001/chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc#newcode124 chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc:124: // Returns true if successful. On 2014/06/17 18:20:23, Lei ...
6 years, 6 months ago (2014-06-17 18:24:13 UTC) #3
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-17 18:32:10 UTC) #4
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-17 18:33:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/340543002/40001
6 years, 6 months ago (2014-06-17 18:34:31 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 21:34:47 UTC) #7
Message was sent while issue was closed. 
Change committed as 277871

Powered by Google App Engine
This is Rietveld 408576698