Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332003002: Enable gallery watches on Mac (Closed)

Created:
6 years, 6 months ago by vandebo (ex-Chrome)
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, extensions-reviews_chromium.org, vandebo (ex-Chrome), Lei Zhang, tommycli, Greg Billock, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable gallery watches on Mac BUG=144491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277549

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix and clean up tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -245 lines) Patch
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 9 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 1 5 chunks +118 lines, -221 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries_private/gallerywatch/test.js View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vandebo (ex-Chrome)
https://codereview.chromium.org/332003002/diff/1/chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc File chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc (left): https://codereview.chromium.org/332003002/diff/1/chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc#oldcode30 chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc:30: #if !defined(OS_CHROMEOS) We'll see what happens when this comes ...
6 years, 6 months ago (2014-06-14 00:45:11 UTC) #1
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-14 00:51:27 UTC) #2
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-14 00:52:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/332003002/1
6 years, 6 months ago (2014-06-14 00:54:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 07:17:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/37716)
6 years, 6 months ago (2014-06-14 07:17:04 UTC) #6
vandebo (ex-Chrome)
Stopped using auto galleries in the test and also pulled out some come code/did some ...
6 years, 6 months ago (2014-06-16 18:38:15 UTC) #7
Lei Zhang
still lgtm
6 years, 6 months ago (2014-06-16 18:48:35 UTC) #8
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 18:49:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/332003002/20001
6 years, 6 months ago (2014-06-16 18:51:13 UTC) #10
commit-bot: I haz the power
Change committed as 277549
6 years, 6 months ago (2014-06-16 22:04:27 UTC) #11
vandebo (ex-Chrome)
6 years, 6 months ago (2014-06-16 23:10:40 UTC) #12
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/334393002/ by vandebo@chromium.org.

The reason for reverting is: Bot crashed:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/b....

Powered by Google App Engine
This is Rietveld 408576698