Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 340513003: DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineView.js
diff --git a/Source/devtools/front_end/timeline/TimelineView.js b/Source/devtools/front_end/timeline/TimelineView.js
index 5d378591c6855e3752dbc0f6e13026f14ea64b1c..5eab0caee9de81e52021592a063c46237e20d0e4 100644
--- a/Source/devtools/front_end/timeline/TimelineView.js
+++ b/Source/devtools/front_end/timeline/TimelineView.js
@@ -652,7 +652,7 @@ WebInspector.TimelineView.prototype = {
var taskIndex = insertionIndexForObjectInListSortedByFunction(startTime, tasks, compareEndTime);
var foreignStyle = "gpu-task-foreign";
- var element = container.firstChild;
+ var element = /** @type {?Element} */ (container.firstChild);
aandrey 2014/06/17 11:33:54 should be no cast
apavlov 2014/06/17 12:46:04 same as above
var lastElement;
var lastLeft;
var lastRight;
@@ -1101,7 +1101,7 @@ WebInspector.TimelineRecordListRow.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
*/
_onExpandClick: function(event)
{

Powered by Google App Engine
This is Rietveld 408576698