Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: Source/devtools/front_end/ui/SidebarPane.js

Issue 340513003: DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ui/SidebarPane.js
diff --git a/Source/devtools/front_end/ui/SidebarPane.js b/Source/devtools/front_end/ui/SidebarPane.js
index 5064d6698a993ba5d58bec375857e118c4dbf670..85ac23037ad080e6660021eaebaab2a37c50cc14 100644
--- a/Source/devtools/front_end/ui/SidebarPane.js
+++ b/Source/devtools/front_end/ui/SidebarPane.js
@@ -126,7 +126,7 @@ WebInspector.SidebarPaneTitle.prototype = {
_expand: function()
{
this.element.classList.add("expanded");
- this._pane.show(this.element.parentNode, this.element.nextSibling);
+ this._pane.show(this.element.parentElement, /** @type {?Element} */ (this.element.nextSibling));
aandrey 2014/06/17 11:33:54 should be no cast (e.g. let pane.show() accept und
apavlov 2014/06/17 12:46:04 This cast is about Node->Element, not about undefi
},
_collapse: function()
@@ -145,7 +145,7 @@ WebInspector.SidebarPaneTitle.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
*/
_onTitleKeyDown: function(event)
{

Powered by Google App Engine
This is Rietveld 408576698