net/quic/quic_stream_factory.cc - Issue 340433002: Port QuicServer to Chrome network stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory.cc

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_stream_factory.cc

diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc

index 9acedcbddb8dea9aa6347d5003d823572ab5b20b..d5a7f878103853fb9bc4a75a532044fe529855b4 100644

--- a/net/quic/quic_stream_factory.cc

+++ b/net/quic/quic_stream_factory.cc

@@ -825,7 +825,7 @@ int QuicStreamFactory::CreateSession(

QuicConnection* connection =

new QuicConnection(connection_id, addr, helper_.get(), writer.get(),

false, supported_versions_);

- writer->SetConnection(connection);

+ writer->SetWriterToUnblock(connection);

connection->set_max_packet_length(max_packet_length_);

InitializeCachedStateInCryptoConfig(server_id, server_info);