net/quic/quic_session_test.cc - Issue 340433002: Port QuicServer to Chrome network stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_session_test.cc

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_session_test.cc

diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc

index d5468e7f2c0609c1fec6e4818d751133b1c04844..98c0979b4902664e8e022baa64ff97608ce9c498 100644

--- a/net/quic/quic_session_test.cc

+++ b/net/quic/quic_session_test.cc

@@ -400,7 +400,7 @@ TEST_P(QuicSessionTest, OnCanWriteBundlesStreams) {

MockPacketWriter* writer =

static_cast<MockPacketWriter*>(

QuicConnectionPeer::GetWriter(session_.connection()));

- EXPECT_CALL(*writer, WritePacket(_, _, _, _)).WillOnce(

+ EXPECT_CALL(*writer, WritePacket(_, _, _, _, _)).WillOnce(

Return(WriteResult(WRITE_STATUS_OK, 0)));

EXPECT_CALL(*send_algorithm, OnPacketSent(_, _, _, _, _)).Times(1);

session_.OnCanWrite();