Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: net/quic/quic_server_packet_writer.h

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_server_packet_writer.h
diff --git a/net/quic/quic_server_packet_writer.h b/net/quic/quic_server_packet_writer.h
index 63829935521019e5712e27410f70bbc38485ff40..4dff495ef8d03031ca347548c01981d1ca8491f0 100644
--- a/net/quic/quic_server_packet_writer.h
+++ b/net/quic/quic_server_packet_writer.h
@@ -11,38 +11,49 @@
#include "net/quic/quic_connection.h"
#include "net/quic/quic_packet_writer.h"
#include "net/quic/quic_protocol.h"
+#include "net/quic/quic_types.h"
#include "net/udp/udp_server_socket.h"
namespace net {
-struct WriteResult;
+class QuicBlockedWriterInterface;
// Chrome specific packet writer which uses a UDPServerSocket for writing
// data.
class QuicServerPacketWriter : public QuicPacketWriter {
public:
- QuicServerPacketWriter();
- explicit QuicServerPacketWriter(UDPServerSocket* socket);
+ QuicServerPacketWriter(UDPServerSocket* socket);
virtual ~QuicServerPacketWriter();
// QuicPacketWriter
- virtual WriteResult WritePacket(const char* buffer,
- size_t buf_len,
- const net::IPAddressNumber& self_address,
- const net::IPEndPoint& peer_address) OVERRIDE;
+ virtual WriteResult WritePacket(
+ const char* buffer,
+ size_t buf_len,
+ const IPAddressNumber& self_address,
+ const IPEndPoint& peer_address,
+ base::Callback<void(WriteResult wr)> callback) OVERRIDE;
Ryan Hamilton 2014/06/19 19:21:29 Consider using a typedef for this type. (And remov
dmz 2014/06/19 20:06:28 Done.
virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;
virtual bool IsWriteBlocked() const OVERRIDE;
virtual void SetWritable() OVERRIDE;
void OnWriteComplete(int rv);
- void SetConnection(QuicConnection* connection) {
- connection_ = connection;
+
+ // Set the writer to notify when writes complete.
+ void SetWriterToUnblock(QuicBlockedWriterInterface* blocked_writer) {
+ blocked_writer_ = blocked_writer;
}
private:
base::WeakPtrFactory<QuicServerPacketWriter> weak_factory_;
UDPServerSocket* socket_;
- QuicConnection* connection_;
+
+ // To be notified after every successful write.
+ QuicBlockedWriterInterface* blocked_writer_;
+
+ // To be called after every successful write. May be null.
+ base::Callback<void(WriteResult wr)> callback_;
+
+ // Whether a write is currently in flight.
bool write_blocked_;
DISALLOW_COPY_AND_ASSIGN(QuicServerPacketWriter);

Powered by Google App Engine
This is Rietveld 408576698