Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: net/quic/quic_server_packet_writer.h

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_ 5 #ifndef NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_
6 #define NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_ 6 #define NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "net/base/ip_endpoint.h" 10 #include "net/base/ip_endpoint.h"
11 #include "net/quic/quic_connection.h" 11 #include "net/quic/quic_connection.h"
12 #include "net/quic/quic_packet_writer.h" 12 #include "net/quic/quic_packet_writer.h"
13 #include "net/quic/quic_protocol.h" 13 #include "net/quic/quic_protocol.h"
14 #include "net/quic/quic_types.h"
14 #include "net/udp/udp_server_socket.h" 15 #include "net/udp/udp_server_socket.h"
15 16
16 namespace net { 17 namespace net {
17 18
18 struct WriteResult; 19 class QuicBlockedWriterInterface;
19 20
20 // Chrome specific packet writer which uses a UDPServerSocket for writing 21 // Chrome specific packet writer which uses a UDPServerSocket for writing
21 // data. 22 // data.
22 class QuicServerPacketWriter : public QuicPacketWriter { 23 class QuicServerPacketWriter : public QuicPacketWriter {
23 public: 24 public:
24 QuicServerPacketWriter(); 25 QuicServerPacketWriter(UDPServerSocket* socket);
25 explicit QuicServerPacketWriter(UDPServerSocket* socket);
26 virtual ~QuicServerPacketWriter(); 26 virtual ~QuicServerPacketWriter();
27 27
28 // QuicPacketWriter 28 // QuicPacketWriter
29 virtual WriteResult WritePacket(const char* buffer, 29 virtual WriteResult WritePacket(
30 size_t buf_len, 30 const char* buffer,
31 const net::IPAddressNumber& self_address, 31 size_t buf_len,
32 const net::IPEndPoint& peer_address) OVERRIDE; 32 const IPAddressNumber& self_address,
33 const IPEndPoint& peer_address,
34 base::Callback<void(WriteResult wr)> callback) OVERRIDE;
Ryan Hamilton 2014/06/19 19:21:29 Consider using a typedef for this type. (And remov
dmz 2014/06/19 20:06:28 Done.
33 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE; 35 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;
34 virtual bool IsWriteBlocked() const OVERRIDE; 36 virtual bool IsWriteBlocked() const OVERRIDE;
35 virtual void SetWritable() OVERRIDE; 37 virtual void SetWritable() OVERRIDE;
36 38
37 void OnWriteComplete(int rv); 39 void OnWriteComplete(int rv);
38 void SetConnection(QuicConnection* connection) { 40
39 connection_ = connection; 41 // Set the writer to notify when writes complete.
42 void SetWriterToUnblock(QuicBlockedWriterInterface* blocked_writer) {
43 blocked_writer_ = blocked_writer;
40 } 44 }
41 45
42 private: 46 private:
43 base::WeakPtrFactory<QuicServerPacketWriter> weak_factory_; 47 base::WeakPtrFactory<QuicServerPacketWriter> weak_factory_;
44 UDPServerSocket* socket_; 48 UDPServerSocket* socket_;
45 QuicConnection* connection_; 49
50 // To be notified after every successful write.
51 QuicBlockedWriterInterface* blocked_writer_;
52
53 // To be called after every successful write. May be null.
54 base::Callback<void(WriteResult wr)> callback_;
55
56 // Whether a write is currently in flight.
46 bool write_blocked_; 57 bool write_blocked_;
47 58
48 DISALLOW_COPY_AND_ASSIGN(QuicServerPacketWriter); 59 DISALLOW_COPY_AND_ASSIGN(QuicServerPacketWriter);
49 }; 60 };
50 61
51 } // namespace net 62 } // namespace net
52 63
53 #endif // NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_ 64 #endif // NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698