Issue 340413003: Revert 277718 "[Hotword] Remove non-English languages due to fea..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340413003: Revert 277718 "[Hotword] Remove non-English languages due to fea..." (Closed)

Created:
6 years, 6 months ago by rpetterson

Modified:
6 years, 6 months ago

Reviewers:
rpetterson

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 277718 "[Hotword] Remove non-English languages due to fea..." Reverting because we do want the feature in M37. > [Hotword] Remove non-English languages due to feature getting bumped to next milestone. > > BUG=385301 > > Review URL: https://codereview.chromium.org/337243003 BUG=345806 TBR=rlp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278420

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -7 lines)			Patch
M	trunk/src/chrome/browser/resources/hotword_helper/manager.js	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/resources/hotword_helper/manifest.json	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/search/hotword_service.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/search/hotword_service_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

rpetterson

6 years, 6 months ago (2014-06-19 17:59:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r278420 (tree was closed).