Issue 337243003: [Hotword] Remove non-English languages due to feature getting bumped to next milestone.

Issue 337243003: [Hotword] Remove non-English languages due to feature getting bumped to next milestone. (Closed)

Created:
6 years, 6 months ago by rpetterson

Modified:
6 years, 6 months ago

Reviewers:
James Hawkins, Jered

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, saurya1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Hotword] Remove non-English languages due to feature getting bumped to next milestone. BUG=385301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277718

Patch Set 1 #

Patch Set 2 : adding manifest chnage #

Patch Set 3 : remove debugging #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -19 lines)			Patch
M	chrome/browser/resources/hotword_helper/manager.js	View	2	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/resources/hotword_helper/manifest.json	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/search/hotword_service.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/search/hotword_service_unittest.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

rpetterson

On 2014/06/17 04:37:39, James Hawkins wrote: > lgtm James, I also added in manifest.json. PTAL?

6 years, 6 months ago (2014-06-17 05:02:27 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/337243003/40001

6 years, 6 months ago (2014-06-17 08:03:23 UTC) #8

Message was sent while issue was closed.

Change committed as 277718

Expand Messages | Collapse Messages