Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: components/dom_distiller/core/dom_distiller_service_android.h

Issue 340403004: Java wrapper for DistilledPagePrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: namespaces to classes, native init, enum Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/dom_distiller_service_android.h
diff --git a/components/dom_distiller/core/dom_distiller_service_android.h b/components/dom_distiller/core/dom_distiller_service_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..494e661897d4040813d460a24fd8a2a883abbd5b
--- /dev/null
+++ b/components/dom_distiller/core/dom_distiller_service_android.h
@@ -0,0 +1,36 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H_
+#define COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H_
+
+#include <jni.h>
+
+#include "base/android/scoped_java_ref.h"
+
nyquist 2014/07/08 01:02:35 Remove empty line.
sunangel 2014/07/08 20:41:00 Done.
+#include "components/dom_distiller/core/dom_distiller_service.h"
+
+namespace dom_distiller{
+namespace android{
+
+class DomDistillerServiceFactoryAndroid;
+
+class DomDistillerServiceAndroid {
nyquist 2014/07/08 01:02:35 What is this class? (add comment to explain).
sunangel 2014/07/08 20:41:00 Done.
+
+ public:
+ friend class DomDistillerServiceFactoryAndroid;
nyquist 2014/07/08 01:02:35 Add a comment which explains why this is needed.
sunangel 2014/07/08 20:41:00 Done.
+ DomDistillerServiceAndroid(dom_distiller::DomDistillerService* ptr);
nyquist 2014/07/08 01:02:34 s/ptr/service/. Also, remove namespace, since you'
sunangel 2014/07/08 20:41:00 Done.
+ static bool Register(JNIEnv* env);
+ virtual ~DomDistillerServiceAndroid();
nyquist 2014/07/08 01:02:35 move up. see http://google-styleguide.googlecode.c
sunangel 2014/07/08 20:41:00 Done.
+ jlong GetDistilledPagePrefsPointer(JNIEnv* env, jobject obj);
+
+ private:
+ base::android::ScopedJavaGlobalRef<jobject> java_ref_;
+ dom_distiller::DomDistillerService* service_;
+};
+
+} // namespace android
+} // namespace dom_distiller
+
+#endif // COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H

Powered by Google App Engine
This is Rietveld 408576698