Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Side by Side Diff: components/dom_distiller/core/dom_distiller_service_android.h

Issue 340403004: Java wrapper for DistilledPagePrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: namespaces to classes, native init, enum Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H_
6 #define COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H_
7
8 #include <jni.h>
9
10 #include "base/android/scoped_java_ref.h"
11
nyquist 2014/07/08 01:02:35 Remove empty line.
sunangel 2014/07/08 20:41:00 Done.
12 #include "components/dom_distiller/core/dom_distiller_service.h"
13
14 namespace dom_distiller{
15 namespace android{
16
17 class DomDistillerServiceFactoryAndroid;
18
19 class DomDistillerServiceAndroid {
nyquist 2014/07/08 01:02:35 What is this class? (add comment to explain).
sunangel 2014/07/08 20:41:00 Done.
20
21 public:
22 friend class DomDistillerServiceFactoryAndroid;
nyquist 2014/07/08 01:02:35 Add a comment which explains why this is needed.
sunangel 2014/07/08 20:41:00 Done.
23 DomDistillerServiceAndroid(dom_distiller::DomDistillerService* ptr);
nyquist 2014/07/08 01:02:34 s/ptr/service/. Also, remove namespace, since you'
sunangel 2014/07/08 20:41:00 Done.
24 static bool Register(JNIEnv* env);
25 virtual ~DomDistillerServiceAndroid();
nyquist 2014/07/08 01:02:35 move up. see http://google-styleguide.googlecode.c
sunangel 2014/07/08 20:41:00 Done.
26 jlong GetDistilledPagePrefsPointer(JNIEnv* env, jobject obj);
27
28 private:
29 base::android::ScopedJavaGlobalRef<jobject> java_ref_;
30 dom_distiller::DomDistillerService* service_;
31 };
32
33 } // namespace android
34 } // namespace dom_distiller
35
36 #endif // COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698