Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: Source/bindings/v8/Dictionary.h

Issue 340353006: [webcrypto] Replace KeyAlgorithm interfaces with an Object. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase onto master Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/modules/v8/custom/custom.gypi ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/Dictionary.h
diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h
index 97b0ee7597a8971aad4e053436e59621d123f564..673d585ebd6dd284e10391515bb72fdc19712c40 100644
--- a/Source/bindings/v8/Dictionary.h
+++ b/Source/bindings/v8/Dictionary.h
@@ -65,6 +65,8 @@ class Dictionary {
ALLOW_ONLY_INLINE_ALLOCATION();
public:
Dictionary();
+ // Creates an empty dictionary
+ explicit Dictionary(v8::Isolate*);
haraken 2014/07/08 04:28:08 Instead of using a constructor, we might want to i
eroman 2014/07/08 19:24:21 I will send you this change in a new changelist! (
Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate*);
~Dictionary();
@@ -107,6 +109,14 @@ public:
bool get(const String&, RefPtr<HeaderMap>&) const;
bool get(const String&, RefPtr<Headers>&) const;
+ // Sets properties using default attributes.
+ bool set(const String&, const v8::Handle<v8::Value>&);
+ bool set(const String&, const String&);
+ bool set(const String&, unsigned);
+ bool set(const String&, const Dictionary&);
+
+ const v8::Handle<v8::Value>& v8Value() const { return m_options; }
abarth-chromium 2014/07/08 02:07:05 No need to return a v8::Handle by const reference.
+
class ConversionContext {
public:
ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState)
« no previous file with comments | « Source/bindings/modules/v8/custom/custom.gypi ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698