Chromium Code Reviews| Index: Source/bindings/v8/Dictionary.h |
| diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h |
| index 97b0ee7597a8971aad4e053436e59621d123f564..673d585ebd6dd284e10391515bb72fdc19712c40 100644 |
| --- a/Source/bindings/v8/Dictionary.h |
| +++ b/Source/bindings/v8/Dictionary.h |
| @@ -65,6 +65,8 @@ class Dictionary { |
| ALLOW_ONLY_INLINE_ALLOCATION(); |
| public: |
| Dictionary(); |
| + // Creates an empty dictionary |
| + explicit Dictionary(v8::Isolate*); |
|
haraken
2014/07/08 04:28:08
Instead of using a constructor, we might want to i
eroman
2014/07/08 19:24:21
I will send you this change in a new changelist! (
|
| Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate*); |
| ~Dictionary(); |
| @@ -107,6 +109,14 @@ public: |
| bool get(const String&, RefPtr<HeaderMap>&) const; |
| bool get(const String&, RefPtr<Headers>&) const; |
| + // Sets properties using default attributes. |
| + bool set(const String&, const v8::Handle<v8::Value>&); |
| + bool set(const String&, const String&); |
| + bool set(const String&, unsigned); |
| + bool set(const String&, const Dictionary&); |
| + |
| + const v8::Handle<v8::Value>& v8Value() const { return m_options; } |
|
abarth-chromium
2014/07/08 02:07:05
No need to return a v8::Handle by const reference.
|
| + |
| class ConversionContext { |
| public: |
| ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState) |