[webcrypto] Replace KeyAlgorithm interfaces with an Object.

Source/bindings/v8/Dictionary.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 47 matching lines @@
 class SpeechRecognitionResult;
 class SpeechRecognitionResultList;
 class Storage;
 class TrackBase;
 class VoidCallback;
 
 class Dictionary {
     ALLOW_ONLY_INLINE_ALLOCATION();
 public:
     Dictionary();
+    // Creates an empty dictionary
+    explicit Dictionary(v8::Isolate*);

[haraken, 2014/07/08 04:28:08]

Instead of using a constructor, we might want to implement
Dictionary::createEmpty(). It's a bit confusing that Dictionary() doesn't
allocate m_options but Dictionary(isolate) allocates m_options.

[eroman, 2014/07/08 19:24:21]

I will send you this change in a new changelist! (Since this one already
landed).

IDL dictionary support is great, is there a bug I can follow to track its
progress? Then I will be sure to update WebCrypto to use it.

     Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate*);
     ~Dictionary();
 
     Dictionary& operator=(const Dictionary&);
 
     bool isObject() const;
     bool isUndefinedOrNull() const;
 
     bool get(const String&, bool&) const;
     bool get(const String&, int32_t&) const;
@@ skipping 22 matching lines @@
     bool get(const String&, RefPtrWillBeMember<EventTarget>&) const;
     bool get(const String&, HashSet<AtomicString>&) const;
     bool get(const String&, Dictionary&) const;
     bool get(const String&, Vector<String>&) const;
     bool get(const String&, ArrayValue&) const;
     bool get(const String&, RefPtrWillBeMember<DOMError>&) const;
     bool get(const String&, v8::Local<v8::Value>&) const;
     bool get(const String&, RefPtr<HeaderMap>&) const;
     bool get(const String&, RefPtr<Headers>&) const;
 
+    // Sets properties using default attributes.
+    bool set(const String&, const v8::Handle<v8::Value>&);
+    bool set(const String&, const String&);
+    bool set(const String&, unsigned);
+    bool set(const String&, const Dictionary&);
+
+    const v8::Handle<v8::Value>& v8Value() const { return m_options; }

[abarth-chromium, 2014/07/08 02:07:05]

No need to return a v8::Handle by const reference.  Just return
v8::Handle<v8::Value>.  It's the size of a pointer.

+
     class ConversionContext {
     public:
         ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState)
             : m_interfaceName(interfaceName)
             , m_methodName(methodName)
             , m_exceptionState(exceptionState)
             , m_dirty(true)
         {
             resetPerPropertyContext();
         }
@@ skipping 224 matching lines @@
     if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
         return true;
 
     context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have a " + context.typeName() + " type."));
     return false;
 }
 
 }
 
 #endif // Dictionary_h