Chromium Code Reviews Chromium Code Reviews
Issue 340323002:
Don't force full invalidation on padding or margin change (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fast/repaint/padding-margin.html |
| diff --git a/LayoutTests/fast/repaint/padding-margin.html b/LayoutTests/fast/repaint/padding-margin.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..c237f0a33bf9f2430d68f14fd9586ab33f522904 |
| --- /dev/null |
| +++ b/LayoutTests/fast/repaint/padding-margin.html |
| @@ -0,0 +1,84 @@ |
| +<!DOCTYPE HTML> |
| +<script src="resources/text-based-repaint.js"></script> |
| +<script> |
| +function repaintTest() |
| +{ |
| + document.getElementById('target1').style.margin = '20px'; |
| + document.getElementById('target1a').style.margin = '20px'; |
| + document.getElementById('target2').style.padding = '20px'; |
| + document.getElementById('target2a').style.padding = '20px'; |
| + |
| + var target3 = document.getElementById('target3'); |
| + target3.style.margin = '20px'; |
| + target3.style.width = '60px'; |
| + target3.style.height = '60px'; |
| + |
| + var target3a = document.getElementById('target3a'); |
| + target3a.style.margin = '20px'; |
| + target3a.style.width = '60px'; |
| + target3a.style.height = '60px'; |
| + |
| + var target4 = document.getElementById('target4'); |
| + target4.style.padding = '20px'; |
| + target4.style.width = '60px'; |
| + target4.style.height = '60px'; |
| + |
| + var target4a = document.getElementById('target4a'); |
| + target4a.style.padding = '20px'; |
| + target4a.style.width = '60px'; |
| + target4a.style.height = '60px'; |
| +} |
|
Julien - ping for review
2014/06/29 01:20:32
This test checks a lot of changes at once ideally
Xianzhu
2014/06/30 22:30:34
Done.
Split into 3 tests:
fast/repaint/margin.htm
|
| +window.onload = runRepaintTest; |
| +</script> |
| +<style> |
| +body { |
| + margin: 0; |
| +} |
| +.outer { |
| + width: 100px; |
| + height: 100px; |
| + position: absolute; |
| + background-color: green; |
| +} |
| +#target1 { |
| + top: 0px; |
| +} |
| +#target1a { |
| + top: 0px; |
| + left: 200px; |
| +} |
| +#target2 { |
| + top: 150px; |
| +} |
| +#target2a { |
| + top: 150px; |
| + left: 200px; |
| +} |
| +#target3 { |
| + top: 300px; |
| +} |
| +#target3a { |
| + top: 300px; |
| + left: 200px; |
| +} |
| +#target4 { |
| + top: 450px; |
| +} |
| +#target4a { |
| + top: 450px; |
| + left: 200px; |
| +} |
| +.inner { |
| + width: 100%; |
| + height: 100%; |
| + background-color: yellow; |
| +} |
| +</style> |
|
Julien - ping for review
2014/06/29 01:20:32
Please add the condition for passing and a descrip
Xianzhu
2014/06/30 22:30:34
Added description.
|
| +<div id="target1" class="outer"></div> |
| +<div id="target1a" class="outer"><div class="inner"></div></div> |
| +<div id="target2" class="outer"></div> |
| +<div id="target2a" class="outer"><div class="inner"></div></div> |
| +<div id="target3" class="outer"></div> |
| +<div id="target3a" class="outer"><div class="inner"></div></div> |
| +<div id="target4" class="outer"></div> |
| +<div id="target4a" class="outer"><div class="inner"></div></div> |
