LayoutTests/fast/repaint/padding-margin.html - Issue 340323002: Don't force full invalidation on padding or margin change

Side by Side Diff: LayoutTests/fast/repaint/padding-margin.html

Issue 340323002: Don't force full invalidation on padding or margin change (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Based on https://codereview.chromium.org/350043003/ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/repaint/box-sizing-padding-keeping-size-expected.txt ('k') | LayoutTests/fast/repaint/padding-margin-expected.txt » ('j') | Source/core/rendering/style/RenderStyle.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="resources/text-based-repaint.js"></script>

	3 <script>

	4 function repaintTest()

	5 {

	6 document.getElementById('target1').style.margin = '20px';

	7 document.getElementById('target1a').style.margin = '20px';

	8 document.getElementById('target2').style.padding = '20px';

	9 document.getElementById('target2a').style.padding = '20px';

	10

	11 var target3 = document.getElementById('target3');

	12 target3.style.margin = '20px';

	13 target3.style.width = '60px';

	14 target3.style.height = '60px';

	15

	16 var target3a = document.getElementById('target3a');

	17 target3a.style.margin = '20px';

	18 target3a.style.width = '60px';

	19 target3a.style.height = '60px';

	20

	21 var target4 = document.getElementById('target4');

	22 target4.style.padding = '20px';

	23 target4.style.width = '60px';

	24 target4.style.height = '60px';

	25

	26 var target4a = document.getElementById('target4a');

	27 target4a.style.padding = '20px';

	28 target4a.style.width = '60px';

	29 target4a.style.height = '60px';

	30 }
	Julien - ping for review 2014/06/29 01:20:32 This test checks a lot of changes at once ideally This test checks a lot of changes at once ideally we shouldn't bundle so many invalidations into a single test as it makes the test fragile and it's possible for one invalidation to hide another one that we missed. I would split this test into 2 or 3 more focused ones. Xianzhu 2014/06/30 22:30:34 Done. Split into 3 tests: fast/repaint/margin.htm Show quoted text On 2014/06/29 01:20:32, Julien Chaffraix - PST wrote: > This test checks a lot of changes at once ideally we shouldn't bundle so many > invalidations into a single test as it makes the test fragile and it's possible > for one invalidation to hide another one that we missed. I would split this test > into 2 or 3 more focused ones. Done. Split into 3 tests: fast/repaint/margin.html fast/repaint/padding-keeping-content-size.html fast/repaint/padding-keeping-visual-size.html
	31 window.onload = runRepaintTest;

	32 </script>

	33 <style>

	34 body {

	35 margin: 0;

	36 }

	37 .outer {

	38 width: 100px;

	39 height: 100px;

	40 position: absolute;

	41 background-color: green;

	42 }

	43 #target1 {

	44 top: 0px;

	45 }

	46 #target1a {

	47 top: 0px;

	48 left: 200px;

	49 }

	50 #target2 {

	51 top: 150px;

	52 }

	53 #target2a {

	54 top: 150px;

	55 left: 200px;

	56 }

	57 #target3 {

	58 top: 300px;

	59 }

	60 #target3a {

	61 top: 300px;

	62 left: 200px;

	63 }

	64 #target4 {

	65 top: 450px;

	66 }

	67 #target4a {

	68 top: 450px;

	69 left: 200px;

	70 }

	71 .inner {

	72 width: 100%;

	73 height: 100%;

	74 background-color: yellow;

	75 }

	76 </style>
	Julien - ping for review 2014/06/29 01:20:32 Please add the condition for passing and a descrip Please add the condition for passing and a description of what you are testing. Invalidation tests are especially difficult to decipher so we should make them cristal clear. Xianzhu 2014/06/30 22:30:34 Added description. Show quoted text On 2014/06/29 01:20:32, Julien Chaffraix - PST wrote: > Please add the condition for passing and a description of what you are testing. > Invalidation tests are especially difficult to decipher so we should make them > cristal clear. Added description.
	77 <div id="target1" class="outer"></div>

	78 <div id="target1a" class="outer"><div class="inner"></div></div>

	79 <div id="target2" class="outer"></div>

	80 <div id="target2a" class="outer"><div class="inner"></div></div>

	81 <div id="target3" class="outer"></div>

	82 <div id="target3a" class="outer"><div class="inner"></div></div>

	83 <div id="target4" class="outer"></div>

	84 <div id="target4a" class="outer"><div class="inner"></div></div>

OLD	NEW