Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Issue 340043002: DevTools: untangle paint profiler for better reuse (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
malch, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: untangle paint profiler for better reuse Make PaintProfilerView and PaintProfilerCommandLogView independent on each other, make them both children of LayerPaintProfilerView and remove layer-specific stuff into the latter, so that the former two operate on just snapshots. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176454

Patch Set 1 #

Patch Set 2 : added missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -82 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +2 lines, -1 line 0 comments Download
A Source/devtools/front_end/layers/LayerPaintProfilerView.js View 1 1 chunk +59 lines, -0 lines 0 comments Download
M Source/devtools/front_end/layers/LayersPanel.js View 4 chunks +13 lines, -2 lines 0 comments Download
M Source/devtools/front_end/layers/PaintProfilerView.js View 6 chunks +82 lines, -77 lines 0 comments Download
M Source/devtools/front_end/layersPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
caseq
6 years, 6 months ago (2014-06-18 12:34:25 UTC) #1
malch
On 2014/06/18 12:34:25, caseq wrote: lgtm
6 years, 6 months ago (2014-06-18 13:12:18 UTC) #2
pfeldman
lgtm
6 years, 6 months ago (2014-06-18 18:28:02 UTC) #3
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-18 19:22:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/340043002/20001
6 years, 6 months ago (2014-06-18 19:23:40 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 20:59:55 UTC) #6
Message was sent while issue was closed.
Change committed as 176454

Powered by Google App Engine
This is Rietveld 408576698