Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1999)

Unified Diff: Source/devtools/front_end/layers/LayersPanel.js

Issue 340043002: DevTools: untangle paint profiler for better reuse (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: added missing file Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/layers/LayersPanel.js
diff --git a/Source/devtools/front_end/layers/LayersPanel.js b/Source/devtools/front_end/layers/LayersPanel.js
index f7e734bb9b8a80743eeb118c8058aa6240f27ce5..3bd508164f09512c1b6392fac115edf9c27146c1 100644
--- a/Source/devtools/front_end/layers/LayersPanel.js
+++ b/Source/devtools/front_end/layers/LayersPanel.js
@@ -31,6 +31,7 @@
importScript("LayerTreeOutline.js");
importScript("LayerDetailsView.js");
importScript("PaintProfilerView.js");
+importScript("LayerPaintProfilerView.js");
/**
* @constructor
@@ -71,7 +72,8 @@ WebInspector.LayersPanel = function()
this._layerDetailsView = new WebInspector.LayerDetailsView();
this._layerDetailsView.addEventListener(WebInspector.LayerDetailsView.Events.ObjectSelected, this._onObjectSelected, this);
this._tabbedPane.appendTab(WebInspector.LayersPanel.DetailsViewTabs.Details, WebInspector.UIString("Details"), this._layerDetailsView);
- this._paintProfilerView = new WebInspector.PaintProfilerView(this._model, this._layers3DView);
+
+ this._paintProfilerView = new WebInspector.LayerPaintProfilerView(this._layers3DView.showImageForLayer.bind(this._layers3DView));
this._tabbedPane.appendTab(WebInspector.LayersPanel.DetailsViewTabs.Profiler, WebInspector.UIString("Profiler"), this._paintProfilerView);
}
@@ -157,7 +159,7 @@ WebInspector.LayersPanel.prototype = {
{
var layer = /** @type {!WebInspector.Layer} */ (event.data);
this._tabbedPane.selectTab(WebInspector.LayersPanel.DetailsViewTabs.Profiler);
- this._paintProfilerView.profile(layer);
+ this._paintProfilerView.profileLayer(layer);
},
/**
@@ -197,6 +199,15 @@ WebInspector.LayersPanel.prototype = {
this._layers3DView.hoverObject(activeObject);
},
+ /**
+ * @param {!WebInspector.Layer} layer
+ * @param {string=} imageURL
+ */
+ _showImageForLayer: function(layer, imageURL)
+ {
+ this._layers3DView.showImageForLayer(layer, imageURL);
+ },
+
__proto__: WebInspector.PanelWithSidebarTree.prototype
}
« no previous file with comments | « Source/devtools/front_end/layers/LayerPaintProfilerView.js ('k') | Source/devtools/front_end/layers/PaintProfilerView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698