Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 340017: Fix the crashes in interactive_ui_tests on Linux.... (Closed)

8 years ago by jam
6 years, 5 months ago


Fix the crashes in interactive_ui_tests on Linux. The cause is really subtle. When I added a db_thread() in BrowserMain, that changed the order that threads were created at. Since interactive ui tests don't run atexitmanager (I filed a bug to make them do), this cascaded into's InFlightIO singelton caching the first IO MessageLoop pointer. By fluke, previously each IO ML would have the exact same pointer value (must be a unique size for the allocator). My change modified the construction order, so the second run would have a different ChromeThread (file) get the previous IO thread's ML pointer. That led to the asserts. I have added code to start the threads in a predictable manner for now. BUG=25354 TEST=interactive_ui_tests in Linux stop crashing Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/ View 2 chunks +6 lines, -4 lines 0 comments Download


Total messages: 4 (0 generated)
8 years ago (2009-10-28 00:22:27 UTC) #1
I'm going to check this in TBR to get the bot green. Will do any ...
8 years ago (2009-10-28 01:12:17 UTC) #2
darin (slow to review)
OK, LGTM Did this have any impact on startup time?
8 years ago (2009-10-28 05:44:51 UTC) #3
8 years ago (2009-10-28 18:21:38 UTC) #4
On Tue, Oct 27, 2009 at 10:44 PM, <> wrote:

> Did this have any impact on startup time?

All the these threads were getting constructed at startup before, I just
made them start in a specific order at once.  I just looked at the perf
tests and I don't see any regressions.


Powered by Google App Engine
This is Rietveld efc10ee0f