Chromium Code Reviews
Help | Chromium Project | Sign in
(616)

Issue 340017: Fix the crashes in interactive_ui_tests on Linux.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by jam
Modified:
2 years, 11 months ago
Reviewers:
darin
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Fix the crashes in interactive_ui_tests on Linux.

The cause is really subtle. When I added a db_thread() in BrowserMain, that changed the order that threads were created at. Since interactive ui tests don't run atexitmanager (I filed a bug to make them do), this cascaded into file_posix.cc's InFlightIO singelton caching the first IO MessageLoop pointer. By fluke, previously each IO ML would have the exact same pointer value (must be a unique size for the allocator). My change modified the construction order, so the second run would have a different ChromeThread (file) get the previous IO thread's ML pointer. That led to the asserts. I have added code to start the threads in a predictable manner for now.

BUG=25354
TEST=interactive_ui_tests in Linux stop crashing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Lint Patch
M chrome/browser/browser_main.cc View 2 chunks +6 lines, -4 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 4
jam
4 years, 5 months ago #1
jam
I'm going to check this in TBR to get the bot green. Will do any ...
4 years, 5 months ago #2
darin
OK, LGTM Did this have any impact on startup time?
4 years, 5 months ago #3
jam
4 years, 5 months ago #4
On Tue, Oct 27, 2009 at 10:44 PM, <darin@chromium.org> wrote:

> OK, LGTM
>
> Did this have any impact on startup time?


All the these threads were getting constructed at startup before, I just
made them start in a specific order at once.  I just looked at the perf
tests and I don't see any regressions.


>
> http://codereview.chromium.org/340017
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6