Fix the crashes in interactive_ui_tests on Linux....

Fix the crashes in interactive_ui_tests on Linux.

The cause is really subtle.  When I added a db_thread() in BrowserMain, that changed the order that threads were created at.  Since interactive ui tests don't run atexitmanager (I filed a bug to make them do), this cascaded into file_posix.cc's InFlightIO singelton caching the first IO MessageLoop pointer.  By fluke, previously each IO ML would have the exact same pointer value (must be a unique size for the allocator).  My change modified the construction order, so the second run would have a different ChromeThread (file) get the previous IO thread's ML pointer.  That led to the asserts.  I have added code to start the threads in a predictable manner for now.

BUG=25354
TEST=interactive_ui_tests in Linux stop crashing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30303

[jam, 2009-10-28 01:12:17]

I'm going to check this in TBR to get the bot green.  Will do any followup
comments in a separate cl.

[darin (slow to review), 2009-10-28 05:44:51]

OK, LGTM

Did this have any impact on startup time?

[jam, 2009-10-28 18:21:38]

On Tue, Oct 27, 2009 at 10:44 PM, <darin@chromium.org> wrote:

> OK, LGTM
>
> Did this have any impact on startup time?


All the these threads were getting constructed at startup before, I just
made them start in a specific order at once.  I just looked at the perf
tests and I don't see any regressions.


>
> http://codereview.chromium.org/340017
>