Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 340013002: Rename {first,last}EditablePosition{After,Before}Position... to denote them returned VisiblePosition (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename {first,last}EditablePosition{After,Before}PositionInRoot to denote them returned VisiblePosion This patch renames {first,last}EditablePosition{After,Before}PositionInRoot to {first,last}EditableVisiblePosition{After,Before}PositionInRoot for having lastEditblePositionBeforePositionInRoot() which returns Position instead of VisiblePosition. This patch is a preparation of fixing issue 339187 by http://crrev.com/340713003 BUG=n/a TEST=n/a Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
6 years, 6 months ago (2014-06-18 09:20:53 UTC) #1
Yuta Kitamura
LGTM The change description can be simpler, I guess...
6 years, 6 months ago (2014-06-18 09:32:04 UTC) #2
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-18 09:35:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/340013002/1
6 years, 6 months ago (2014-06-18 09:36:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 11:28:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12474)
6 years, 6 months ago (2014-06-18 11:28:00 UTC) #6
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-19 00:55:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/340013002/1
6 years, 6 months ago (2014-06-19 00:56:05 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 01:31:59 UTC) #9
Message was sent while issue was closed.
Change committed as 176475

Powered by Google App Engine
This is Rietveld 408576698