Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: Source/core/editing/DeleteSelectionCommand.cpp

Issue 340013002: Rename {first,last}EditablePosition{After,Before}Position... to denote them returned VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/DeleteSelectionCommand.cpp
diff --git a/Source/core/editing/DeleteSelectionCommand.cpp b/Source/core/editing/DeleteSelectionCommand.cpp
index d7f5f19cfe247d04db5066ccc4d2a47d8c562e05..54e05ac2a2b48ce8c5839889b39347982957f06b 100644
--- a/Source/core/editing/DeleteSelectionCommand.cpp
+++ b/Source/core/editing/DeleteSelectionCommand.cpp
@@ -166,7 +166,7 @@ void DeleteSelectionCommand::initializePositionData()
ASSERT(isEditablePosition(start, ContentIsEditable, DoNotUpdateStyle));
if (!isEditablePosition(end, ContentIsEditable, DoNotUpdateStyle))
- end = lastEditablePositionBeforePositionInRoot(end, highestEditableRoot(start)).deepEquivalent();
+ end = lastEditableVisiblePositionBeforePositionInRoot(end, highestEditableRoot(start)).deepEquivalent();
m_upstreamStart = start.upstream();
m_downstreamStart = start.downstream();
« no previous file with comments | « no previous file | Source/core/editing/SpellChecker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698