Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340003002: Revert of views: Move MenuButton from TextButton to LabelButton. (Closed)

Created:
6 years, 6 months ago by jackhou1
Modified:
6 years, 6 months ago
Reviewers:
msw, Elliot Glaysher, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, benquan, tfarina, Dane Wallinga, dyu1, chromium-apps-reviews_chromium.org, estade+watch_chromium.org, markusheintz_, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Revert of views: Move MenuButton from TextButton to LabelButton. (https://codereview.chromium.org/298813002/) Reason for revert: This is causes ExtensionApiTest.Bookmarks to fail on Linux: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5412 http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32272 TBR=erg@chromium.org,msw@chromium.org,sky@chromium.org NOTRY=true NOTREECHECKS=true Original issue's description: > views: Move MenuButton from TextButton to LabelButton. > > This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases. > > This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux. > > BUG=155363 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277878 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -309 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_border.h View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_border.cc View 4 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 19 chunks +44 lines, -73 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 34 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_label.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 5 chunks +26 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_view.cc View 8 chunks +22 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 4 chunks +7 lines, -33 lines 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_toolbar_button.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 3 chunks +24 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_box_view.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/button_drag_utils.h View 2 chunks +1 line, -12 lines 0 comments Download
M ui/views/button_drag_utils.cc View 3 chunks +6 lines, -18 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/label_button.h View 3 chunks +1 line, -9 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 4 chunks +5 lines, -6 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 8 chunks +7 lines, -19 lines 0 comments Download
M ui/views/controls/button/radio_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/linux_ui/linux_ui.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jackhou1
Created Revert of views: Move MenuButton from TextButton to LabelButton.
6 years, 6 months ago (2014-06-18 07:21:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/340003002/1
6 years, 6 months ago (2014-06-18 07:23:55 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 07:23:56 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-18 07:23:57 UTC) #4
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 6 months ago (2014-06-18 07:28:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/340003002/1
6 years, 6 months ago (2014-06-18 07:33:12 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 07:39:50 UTC) #7
Message was sent while issue was closed. 
Change committed as 277974

Powered by Google App Engine
This is Rietveld 408576698