Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2447)

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.cc

Issue 340003002: Revert of views: Move MenuButton from TextButton to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/content_setting_bubble_contents.cc
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.cc b/chrome/browser/ui/views/content_setting_bubble_contents.cc
index 59f12aca61f274c8fe9f4623a147d53c34973e05..5980bb69fa30a04679c9ce92cc7672b472e1f78f 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.cc
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.cc
@@ -293,7 +293,9 @@
views::MenuButton* menu_button = new views::MenuButton(
NULL, base::UTF8ToUTF16((i->second.selected_device.name)),
this, true);
- menu_button->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ menu_button->set_alignment(views::TextButton::ALIGN_LEFT);
+ menu_button->SetBorder(scoped_ptr<views::Border>(
+ new views::TextButtonNativeThemeBorder(menu_button)));
menu_button->set_animate_on_state_change(false);
MediaMenuParts* menu_view = new MediaMenuParts(i->first);
@@ -335,8 +337,8 @@
// Set all the menu buttons to the width we calculated above.
for (MediaMenuPartsMap::const_iterator i = media_menus_.begin();
i != media_menus_.end(); ++i) {
- i->first->set_min_size(gfx::Size(menu_width, 0));
- i->first->set_max_size(gfx::Size(menu_width, 0));
+ i->first->set_min_width(menu_width);
+ i->first->set_max_width(menu_width);
}
}
@@ -465,7 +467,7 @@
int ContentSettingBubbleContents::GetPreferredMediaMenuWidth(
views::MenuButton* button,
ui::SimpleMenuModel* menu_model) {
- base::string16 title = button->GetText();
+ base::string16 title = button->text();
int width = button->GetPreferredSize().width();
for (int i = 0; i < menu_model->GetItemCount(); ++i) {
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc ('k') | chrome/browser/ui/views/find_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698