Remove --enable-service-worker flag

Remove --enable-service-worker flag

Now the --experimental-web-platform-features flag solely controls whether
Service Worker is web-exposed.

This lets us remove a virtual test suite and also exposes more of SW to perf
and crash monitoring before actually shipping.

BUG=365201
TBR=tonyg

[falken, 2014-06-18 09:39:02]

Sorry for going back and forth on this... I still think removing the service
worker flag entirely is the better step to the goal of shipping, as per the
discussion in http://crbug.com/365201 particularly comment #16. Although there
can be odd state reached if the web platform features flag is flipped on and
off, it won't have much practical impact. If all goes well, we are removing SW
from that flag within weeks anyway, so it seems valuable to incrementally expose
the bits of code we can (without actually shipping) to discover any issues more
quickly.

We could also replace the existing --enable-service-worker checks with
--enable-experimental-web-platform-features now and incrementally remove them
later, but it seems we might as well just leave them out now and if there's
problems we can always add them. WDYT?

[michaeln, 2014-06-19 00:21:07]

lgtm

[Tom Sepez, 2014-06-19 00:56:45]

I don't think you need my approval for this, so removing from reviewers line. 
Thanks.

[falken, 2014-06-19 03:14:13]

+scheib: can you give OWNER review for extensions please?

[falken, 2014-06-19 13:34:34]

+jam for content/ OWNER

[jam, 2014-06-19 16:44:18]

lgtm

[jsbell, 2014-06-19 18:34:32]

Note that this needs to wait until Blink r176500 rolls into DEPS.

[not at google - send to devlin, 2014-06-19 21:28:38]

lgtm

[falken, 2014-06-20 00:35:56]

+tonyg for tools/perf

[jsbell, 2014-06-20 04:28:30]

On 2014/06/20 00:35:56, falken wrote:
> +tonyg for tools/perf

I think you can TBR that.

[falken, 2014-06-20 13:10:39]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-06-20 13:12:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/339973003/20001

[tonyg, 2014-06-20 15:49:10]

lgtm

[commit-bot: I haz the power, 2014-06-20 16:40:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[jsbell, 2014-06-20 17:18:17]

On 2014/06/20 16:40:24, I haz the power (commit-bot) wrote:
> FYI, CQ is re-trying this CL (attempt #1).
> The failing builders are:
>   android_dbg_triggered_tests on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
>   linux_chromium_chromeos_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
>   linux_chromium_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
>   mac_chromium_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
>   win_chromium_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
>   win_chromium_x64_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

The failures look legit - I see these fail locally with this patch:

ServiceWorkerVersionBrowserTest.Activate_Rejected
ServiceWorkerVersionBrowserTest.FetchEvent_Response
ServiceWorkerVersionBrowserTest.InstallWithWaitUntil_Rejected
ServiceWorkerVersionBrowserTest.SyncEventHandled

I'll try and dig in.

[jsbell, 2014-06-20 17:30:01]

On 2014/06/20 17:18:17, jsbell wrote:
> On 2014/06/20 16:40:24, I haz the power (commit-bot) wrote:
> > FYI, CQ is re-trying this CL (attempt #1).
> > The failing builders are:
> >   android_dbg_triggered_tests on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
> >   linux_chromium_chromeos_rel on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
> >   linux_chromium_rel on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
> >   mac_chromium_rel on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
> >   win_chromium_rel on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
> >   win_chromium_x64_rel on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
> 
> The failures look legit - I see these fail locally with this patch:
> 
> ServiceWorkerVersionBrowserTest.Activate_Rejected
> ServiceWorkerVersionBrowserTest.FetchEvent_Response
> ServiceWorkerVersionBrowserTest.InstallWithWaitUntil_Rejected
> ServiceWorkerVersionBrowserTest.SyncEventHandled
> 
> I'll try and dig in.

Looks like we need to still pass in kEnableExperimentalWebPlatformFeatures in
ServiceWorkerBrowserTest

I'll upload a cloned patch and CQ it.

[jsbell, 2014-06-20 17:34:55]

On 2014/06/20 17:30:01, jsbell wrote:
> I'll upload a cloned patch and CQ it.

FYI: https://codereview.chromium.org/348843003

[commit-bot: I haz the power, 2014-06-20 19:36:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-20 19:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:59:20]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[jsbell, 2014-06-20 23:51:11]

On 2014/06/20 17:34:55, jsbell wrote:
> On 2014/06/20 17:30:01, jsbell wrote:
> > I'll upload a cloned patch and CQ it.
> 
> FYI: https://codereview.chromium.org/348843003

And I just manually landed that.