Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 348843003: Remove --enable-service-worker flag (Closed)

Created:
6 years, 6 months ago by jsbell
Modified:
6 years, 6 months ago
CC:
chromium-reviews, michaeln, extensions-reviews_chromium.org, serviceworker-reviews, creis+watch_chromium.org, tzik, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, chromium-apps-reviews_chromium.org, jsbell+serviceworker_chromium.org, alecflett+watch_chromium.org, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove --enable-service-worker flag Now the --experimental-web-platform-features flag solely controls whether Service Worker is web-exposed. This lets us remove a virtual test suite and also exposes more of SW to perf and crash monitoring before actually shipping. This is a clone of https://codereview.chromium.org/339973003/ by falken@ with a trivial browsertest fix. BUG=365201 TBR=falken,michaeln,jam,kalman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -104 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 3 chunks +2 lines, -47 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_utils.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/manifest_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/background_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/service_worker.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-20 17:34:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/348843003/1
6 years, 6 months ago (2014-06-20 17:42:20 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 22:04:09 UTC) #3
jsbell
Committed patchset #1 manually as r278868 (presubmit successful).
6 years, 6 months ago (2014-06-20 23:50:24 UTC) #4
falken
6 years, 6 months ago (2014-06-20 23:59:14 UTC) #5
Message was sent while issue was closed.
On 2014/06/20 23:50:24, jsbell wrote:
> Committed patchset #1 manually as r278868 (presubmit successful).

Thanks for picking this up!
(I thought I had run all SW browser tests before submitting, but apparently not.
Sorry about that.)

Powered by Google App Engine
This is Rietveld 408576698