Fix flaky AppsGridViewTest on valgrind bot.

Fix flaky AppsGridViewTest on valgrind bot.

- Remove local test timeouts;
- Add page flip history to PageFlipWaiter and use that for test expectations
  to solve the problem that a single Wait returns with multiple page flipping
  happened on valgrind;

BUG=385167
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278049

[Lei Zhang, 2014-06-17 20:44:44]

tools/valgrind lgtm

[stevenjb, 2014-06-17 21:20:45]

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
File ui/app_list/views/apps_grid_view_unittest.cc (right):

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view_unittest.cc:519: while
(page_flip_waiter.selected_pages() != "1,2") {
nit: Could we wait on while(test_api_->HasPendingPageFlip() instead, then do an
EXPECT check after which would be more informative in the case of a failure (vs.
a timeout)?

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view_unittest.cc:523: // Stay there longer and no
page flip happen since we are at the last page.
Update comment

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view_unittest.cc:536: while
(page_flip_waiter.selected_pages() != "1,0") {
Here too

[xiyuan, 2014-06-17 21:32:44]

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
File ui/app_list/views/apps_grid_view_unittest.cc (right):

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view_unittest.cc:519: while
(page_flip_waiter.selected_pages() != "1,2") {
On 2014/06/17 21:20:44, stevenjb wrote:
> nit: Could we wait on while(test_api_->HasPendingPageFlip() instead, then do
an
> EXPECT check after which would be more informative in the case of a failure
(vs.
> a timeout)?

Done.

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view_unittest.cc:523: // Stay there longer and no
page flip happen since we are at the last page.
On 2014/06/17 21:20:44, stevenjb wrote:
> Update comment

Comment here is removed and added "then stop" to comment at line 517.

https://codereview.chromium.org/339933005/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view_unittest.cc:536: while
(page_flip_waiter.selected_pages() != "1,0") {
On 2014/06/17 21:20:44, stevenjb wrote:
> Here too

Done.

[stevenjb, 2014-06-17 22:00:36]

lgtm

[xiyuan, 2014-06-17 22:01:37]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-06-17 22:03:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/339933005/20001

[commit-bot: I haz the power, 2014-06-18 13:07:52]

Change committed as 278049