Fix flaky AppsGridViewTest on valgrind bot.

ui/app_list/views/apps_grid_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/apps_grid_view.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/timer/timer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/app_list/app_list_constants.h"
 #include "ui/app_list/app_list_folder_item.h"
 #include "ui/app_list/app_list_item.h"
 #include "ui/app_list/app_list_model.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/pagination_model.h"
 #include "ui/app_list/test/app_list_test_model.h"
 #include "ui/app_list/views/app_list_item_view.h"
 #include "ui/app_list/views/apps_grid_view_folder_delegate.h"
 #include "ui/app_list/views/test/apps_grid_view_test_api.h"
 #include "ui/views/test/views_test_base.h"
 
 namespace app_list {
 namespace test {
 
 namespace {
 
 const int kIconDimension = 48;
 const int kCols = 2;
 const int kRows = 2;
 const int kTilesPerPage = kCols * kRows;
 
 const int kWidth = 320;
 const int kHeight = 240;
 
 class PageFlipWaiter : public PaginationModelObserver {
  public:
   PageFlipWaiter(base::MessageLoopForUI* ui_loop, PaginationModel* model)
-      : ui_loop_(ui_loop), model_(model), wait_(false), page_changed_(false) {
+      : ui_loop_(ui_loop), model_(model), wait_(false) {
     model_->AddObserver(this);
   }
 
   virtual ~PageFlipWaiter() {
     model_->RemoveObserver(this);
   }
 
-  bool Wait(int time_out_ms) {
+  void Wait() {
     DCHECK(!wait_);
     wait_ = true;
-    page_changed_ = false;
-
-    if (time_out_ms) {
-      wait_timer_.Stop();
-      wait_timer_.Start(FROM_HERE,
-                        base::TimeDelta::FromMilliseconds(time_out_ms),
-                        this, &PageFlipWaiter::OnWaitTimeOut);
-    }
 
     ui_loop_->Run();
     wait_ = false;
-    return page_changed_;
   }
 
+  void Reset() { selected_pages_.clear(); }
+
+  const std::string& selected_pages() const { return selected_pages_; }
+
  private:
-  void OnWaitTimeOut() {
-    ui_loop_->Quit();
-  }
-
   // PaginationModelObserver overrides:
   virtual void TotalPagesChanged() OVERRIDE {
   }
   virtual void SelectedPageChanged(int old_selected,
                                    int new_selected) OVERRIDE {
-    page_changed_ = true;
+    if (!selected_pages_.empty())
+      selected_pages_ += ',';
+    selected_pages_ += base::IntToString(new_selected);
+
     if (wait_)
       ui_loop_->Quit();
   }
   virtual void TransitionStarted() OVERRIDE {
   }
   virtual void TransitionChanged() OVERRIDE {
   }
 
   base::MessageLoopForUI* ui_loop_;
   PaginationModel* model_;
   bool wait_;
-  bool page_changed_;
-  base::OneShotTimer<PageFlipWaiter> wait_timer_;
+  std::string selected_pages_;
 
   DISALLOW_COPY_AND_ASSIGN(PageFlipWaiter);
 };
 
 }  // namespace
 
 class AppsGridViewTest : public views::ViewsTestBase {
  public:
   AppsGridViewTest() {}
   virtual ~AppsGridViewTest() {}
@@ skipping 407 matching lines @@
   const int kPages = 3;
   model_->PopulateApps(kPages * kTilesPerPage);
   EXPECT_EQ(kPages, GetPaginationModel()->total_pages());
   EXPECT_EQ(0, GetPaginationModel()->selected_page());
 
   gfx::Point from = GetItemTileRectAt(0, 0).CenterPoint();
   gfx::Point to = gfx::Point(apps_grid_view_->width(),
                              apps_grid_view_->height() / 2);
 
   // Drag to right edge.
+  page_flip_waiter.Reset();
   SimulateDrag(AppsGridView::MOUSE, from, to);
 
-  // Page should be flipped after sometime.
-  EXPECT_TRUE(page_flip_waiter.Wait(0));
-  EXPECT_EQ(1, GetPaginationModel()->selected_page());
-
-  // Stay there and page should be flipped again.
-  EXPECT_TRUE(page_flip_waiter.Wait(0));
-  EXPECT_EQ(2, GetPaginationModel()->selected_page());
+  // Page should be flipped after sometime to hit page 1 and 2.
+  EXPECT_TRUE(test_api_->HasPendingPageFlip());
+  while (page_flip_waiter.selected_pages() != "1,2") {

[stevenjb, 2014/06/17 21:20:44]

nit: Could we wait on while(test_api_->HasPendingPageFlip() instead, then do an
EXPECT check after which would be more informative in the case of a failure (vs.
a timeout)?

[xiyuan, 2014/06/17 21:32:44]

Done.

+    page_flip_waiter.Wait();
+  }
 
   // Stay there longer and no page flip happen since we are at the last page.

[stevenjb, 2014/06/17 21:20:44]

Update comment

[xiyuan, 2014/06/17 21:32:44]

Comment here is removed and added "then stop" to comment at line 517.

-  EXPECT_FALSE(page_flip_waiter.Wait(100));
+  EXPECT_FALSE(test_api_->HasPendingPageFlip());
   EXPECT_EQ(2, GetPaginationModel()->selected_page());
 
   apps_grid_view_->EndDrag(true);
 
   // Now drag to the left edge and test the other direction.
   to.set_x(0);
 
+  page_flip_waiter.Reset();
   SimulateDrag(AppsGridView::MOUSE, from, to);
 
-  EXPECT_TRUE(page_flip_waiter.Wait(0));
-  EXPECT_EQ(1, GetPaginationModel()->selected_page());
+  EXPECT_TRUE(test_api_->HasPendingPageFlip());
+  while (page_flip_waiter.selected_pages() != "1,0") {

[stevenjb, 2014/06/17 21:20:44]

Here too

[xiyuan, 2014/06/17 21:32:44]

Done.

+    page_flip_waiter.Wait();
+  }
 
-  EXPECT_TRUE(page_flip_waiter.Wait(0));
-  EXPECT_EQ(0, GetPaginationModel()->selected_page());
-
-  EXPECT_FALSE(page_flip_waiter.Wait(100));
+  EXPECT_FALSE(test_api_->HasPendingPageFlip());
   EXPECT_EQ(0, GetPaginationModel()->selected_page());
   apps_grid_view_->EndDrag(true);
 }
 
 TEST_F(AppsGridViewTest, SimultaneousDragWithFolderDisabled) {
   model_->SetFoldersEnabled(false);
   const int kTotalItems = 4;
   model_->PopulateApps(kTotalItems);
   EXPECT_EQ(std::string("Item 0,Item 1,Item 2,Item 3"),
             model_->GetModelContent());
@@ skipping 154 matching lines @@
   AppListItemView* item_view = GetItemViewAt(0);
   ASSERT_TRUE(item_view);
   const views::Label* title_label = item_view->title();
   EXPECT_FALSE(title_label->GetTooltipText(
       title_label->bounds().CenterPoint(), &actual_tooltip));
   EXPECT_EQ(title, base::UTF16ToUTF8(title_label->text()));
 }
 
 }  // namespace test
 }  // namespace app_list