Issue 3397002: Move blob URL scheme registration from test_shell.cc to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3397002: Move blob URL scheme registration from test_shell.cc to... (Closed)

Created:
10 years, 3 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 6 months ago

Reviewers:
jianli

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move blob URL scheme registration from test_shell.cc to simple_resource_loader_bridge.cc, so that it happens for both test_shell and the Chromium DRT (allowing blob layout tests to pass with the latter too). BUG=55587 TEST=blob-related layout tests (with both test_shell and DRT) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59406

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -14 lines)			Patch
M	webkit/support/webkit_support.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_resource_loader_bridge.cc	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	3 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for fixing this.

Expand Messages | Collapse Messages