Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339533002: setData() of DataTransfer has a void return type (Closed)

Created:
6 years, 6 months ago by jinwoo7.song
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

setData() of DataTransfer has a void return type According to HTML5 spec, setData() of DataTranfer interface does not return value. http://www.w3.org/TR/html/editing.html#the-datatransfer-interface This change also has been applied to WebKit by below patch. https://bugs.webkit.org/show_bug.cgi?id=133108 BUG=384952 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176578

Patch Set 1 #

Patch Set 2 : Add test case. #

Total comments: 2

Patch Set 3 : Patch for landing. #

Total comments: 1

Patch Set 4 : Removed unnecessary argument. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
A LayoutTests/editing/pasteboard/set_data_typeof_return.html View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/editing/pasteboard/set_data_typeof_return-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/clipboard/Clipboard.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/Clipboard.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/clipboard/DataObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/DataObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/clipboard/DataTransfer.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tkent
What about IE and Firefox behavior?
6 years, 6 months ago (2014-06-18 07:20:19 UTC) #1
jinwoo7.song
On 2014/06/18 07:20:19, tkent wrote: > What about IE and Firefox behavior? Firefox is following ...
6 years, 6 months ago (2014-06-18 07:27:21 UTC) #2
tkent
It seems this bool was intentional for IE compatibility. http://trac.webkit.org/changeset/6709 The return type is void ...
6 years, 6 months ago (2014-06-18 07:55:32 UTC) #3
jinwoo7.song
On 2014/06/18 07:55:32, tkent wrote: > It seems this bool was intentional for IE compatibility. ...
6 years, 6 months ago (2014-06-19 07:27:04 UTC) #4
tkent
https://codereview.chromium.org/339533002/diff/20001/LayoutTests/editing/pasteboard/set_data_typeof_return.html File LayoutTests/editing/pasteboard/set_data_typeof_return.html (right): https://codereview.chromium.org/339533002/diff/20001/LayoutTests/editing/pasteboard/set_data_typeof_return.html#newcode8 LayoutTests/editing/pasteboard/set_data_typeof_return.html:8: shouldBeUndefined("event.clipboardData.setData('text/plain', 'copy test')"); The argument 'e' is unnecessary. window.event ...
6 years, 6 months ago (2014-06-19 08:29:16 UTC) #5
jinwoo7.song
On 2014/06/19 08:29:16, tkent wrote: > https://codereview.chromium.org/339533002/diff/20001/LayoutTests/editing/pasteboard/set_data_typeof_return.html > File LayoutTests/editing/pasteboard/set_data_typeof_return.html (right): > > https://codereview.chromium.org/339533002/diff/20001/LayoutTests/editing/pasteboard/set_data_typeof_return.html#newcode8 > ...
6 years, 6 months ago (2014-06-20 00:02:43 UTC) #6
tkent
https://codereview.chromium.org/339533002/diff/40001/LayoutTests/editing/pasteboard/set_data_typeof_return.html File LayoutTests/editing/pasteboard/set_data_typeof_return.html (right): https://codereview.chromium.org/339533002/diff/40001/LayoutTests/editing/pasteboard/set_data_typeof_return.html#newcode12 LayoutTests/editing/pasteboard/set_data_typeof_return.html:12: <body oncopy="setDataTest(event)"> |event| argument is unnecessary.
6 years, 6 months ago (2014-06-20 00:10:48 UTC) #7
jinwoo7.song
On 2014/06/20 00:10:48, tkent wrote: > https://codereview.chromium.org/339533002/diff/40001/LayoutTests/editing/pasteboard/set_data_typeof_return.html > File LayoutTests/editing/pasteboard/set_data_typeof_return.html (right): > > https://codereview.chromium.org/339533002/diff/40001/LayoutTests/editing/pasteboard/set_data_typeof_return.html#newcode12 > ...
6 years, 6 months ago (2014-06-20 00:58:48 UTC) #8
tkent
lgtm
6 years, 6 months ago (2014-06-20 01:06:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinwoo7.song@samsung.com/339533002/60001
6 years, 6 months ago (2014-06-20 01:07:59 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 02:12:16 UTC) #11
Message was sent while issue was closed. 
Change committed as 176578

Powered by Google App Engine
This is Rietveld 408576698