Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/core/clipboard/DataObject.cpp

Issue 339533002: setData() of DataTransfer has a void return type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unnecessary argument. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/clipboard/DataObject.h ('k') | Source/core/clipboard/DataTransfer.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2008, 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (c) 2008, 2009, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 145
146 String DataObject::getData(const String& type) const 146 String DataObject::getData(const String& type) const
147 { 147 {
148 for (size_t i = 0; i < m_itemList.size(); ++i) { 148 for (size_t i = 0; i < m_itemList.size(); ++i) {
149 if (m_itemList[i]->kind() == DataObjectItem::StringKind && m_itemList[i] ->type() == type) 149 if (m_itemList[i]->kind() == DataObjectItem::StringKind && m_itemList[i] ->type() == type)
150 return m_itemList[i]->getAsString(); 150 return m_itemList[i]->getAsString();
151 } 151 }
152 return String(); 152 return String();
153 } 153 }
154 154
155 bool DataObject::setData(const String& type, const String& data) 155 void DataObject::setData(const String& type, const String& data)
156 { 156 {
157 clearData(type); 157 clearData(type);
158 if (!add(data, type)) 158 if (!add(data, type))
159 ASSERT_NOT_REACHED(); 159 ASSERT_NOT_REACHED();
160 return true;
161 } 160 }
162 161
163 void DataObject::urlAndTitle(String& url, String* title) const 162 void DataObject::urlAndTitle(String& url, String* title) const
164 { 163 {
165 RefPtrWillBeRawPtr<DataObjectItem> item = findStringItem(mimeTypeTextURIList ); 164 RefPtrWillBeRawPtr<DataObjectItem> item = findStringItem(mimeTypeTextURIList );
166 if (!item) 165 if (!item)
167 return; 166 return;
168 url = convertURIListToURL(item->getAsString()); 167 url = convertURIListToURL(item->getAsString());
169 if (title) 168 if (title)
170 *title = item->title(); 169 *title = item->title();
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 m_itemList.append(item); 257 m_itemList.append(item);
259 } 258 }
260 259
261 void DataObject::trace(Visitor* visitor) 260 void DataObject::trace(Visitor* visitor)
262 { 261 {
263 visitor->trace(m_itemList); 262 visitor->trace(m_itemList);
264 WillBeHeapSupplementable<DataObject>::trace(visitor); 263 WillBeHeapSupplementable<DataObject>::trace(visitor);
265 } 264 }
266 265
267 } // namespace WebCore 266 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/clipboard/DataObject.h ('k') | Source/core/clipboard/DataTransfer.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698