Source/web/WebLocalFrameImpl.h - Issue 339513002: Fix use-after-free when creating and detaching iframe during load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.h

Issue 339513002: Fix use-after-free when creating and detaching iframe during load. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove test since this is already covered by multiple, similar tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.h

diff --git a/Source/web/WebLocalFrameImpl.h b/Source/web/WebLocalFrameImpl.h

index 262f35a957ee2257c46a343b1731ce974e57b763..1ae010cd2e9695a5828ac9adf9761c043338920b 100644

--- a/Source/web/WebLocalFrameImpl.h

+++ b/Source/web/WebLocalFrameImpl.h

@@ -313,7 +313,7 @@ public:

// Invalidates both content area and the scrollbar.

void invalidateAll() const;

- void initializeAsChildFrame(WebCore::FrameHost*, WebCore::FrameOwner*, const AtomicString& name, const AtomicString& fallbackName);

+ PassRefPtr<WebCore::LocalFrame> initializeAsChildFrame(WebCore::FrameHost*, WebCore::FrameOwner*, const AtomicString& name, const AtomicString& fallbackName);

private:

friend class FrameLoaderClientImpl;

« no previous file with comments | « no previous file | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »