Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Side by Side Diff: Source/web/WebLocalFrameImpl.h

Issue 339513002: Fix use-after-free when creating and detaching iframe during load. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove test since this is already covered by multiple, similar tests. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 // Returns the text finder object if it already exists. 306 // Returns the text finder object if it already exists.
307 // Otherwise creates it and then returns. 307 // Otherwise creates it and then returns.
308 TextFinder& ensureTextFinder(); 308 TextFinder& ensureTextFinder();
309 309
310 // Invalidates vertical scrollbar only. 310 // Invalidates vertical scrollbar only.
311 void invalidateScrollbar() const; 311 void invalidateScrollbar() const;
312 312
313 // Invalidates both content area and the scrollbar. 313 // Invalidates both content area and the scrollbar.
314 void invalidateAll() const; 314 void invalidateAll() const;
315 315
316 void initializeAsChildFrame(WebCore::FrameHost*, WebCore::FrameOwner*, const AtomicString& name, const AtomicString& fallbackName); 316 PassRefPtr<WebCore::LocalFrame> initializeAsChildFrame(WebCore::FrameHost*, WebCore::FrameOwner*, const AtomicString& name, const AtomicString& fallbackName );
317 317
318 private: 318 private:
319 friend class FrameLoaderClientImpl; 319 friend class FrameLoaderClientImpl;
320 320
321 explicit WebLocalFrameImpl(WebFrameClient*); 321 explicit WebLocalFrameImpl(WebFrameClient*);
322 322
323 // Sets the local WebCore frame and registers destruction observers. 323 // Sets the local WebCore frame and registers destruction observers.
324 void setWebCoreFrame(PassRefPtr<WebCore::LocalFrame>); 324 void setWebCoreFrame(PassRefPtr<WebCore::LocalFrame>);
325 325
326 void loadJavaScriptURL(const WebCore::KURL&); 326 void loadJavaScriptURL(const WebCore::KURL&);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 UserMediaClientImpl m_userMediaClientImpl; 359 UserMediaClientImpl m_userMediaClientImpl;
360 360
361 OwnPtr<GeolocationClientProxy> m_geolocationClientProxy; 361 OwnPtr<GeolocationClientProxy> m_geolocationClientProxy;
362 }; 362 };
363 363
364 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame()); 364 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());
365 365
366 } // namespace blink 366 } // namespace blink
367 367
368 #endif 368 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698