Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339493006: Move divider detection and creation onto TimelineUIUtils instance (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Move divider detection and creation onto TimelineUIUtils instance BUG=361045 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -54 lines) Patch
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineOverviewPane.js View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 5 chunks +18 lines, -46 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js View 4 chunks +63 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 4 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yurys
6 years, 6 months ago (2014-06-18 15:25:45 UTC) #1
loislo
lgtm
6 years, 6 months ago (2014-06-18 15:31:54 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-18 15:33:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/339493006/1
6 years, 6 months ago (2014-06-18 15:34:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 17:22:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11892)
6 years, 6 months ago (2014-06-18 17:22:28 UTC) #6
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-19 06:55:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/339493006/1
6 years, 6 months ago (2014-06-19 06:56:28 UTC) #8
yurys
6 years, 6 months ago (2014-06-19 07:11:18 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 manually as r176493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698