Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 339493006: Move divider detection and creation onto TimelineUIUtils instance (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 7378848d8199384cd41031c651edebb86bb7f2b1..f264de7410ef45d7cd451ad6d34d033d09d83b36 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -61,6 +61,14 @@ WebInspector.TimelineUIUtils.prototype = {
},
/**
* @param {!WebInspector.TimelineModel.Record} record
+ * @return {boolean}
+ */
+ isEventDivider: function(record)
+ {
+ throw new Error("Not implemented.");
+ },
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
* @return {?Object}
*/
countersForRecord: function(record)
@@ -95,6 +103,15 @@ WebInspector.TimelineUIUtils.prototype = {
generateDetailsContent: function(record, model, linkifier, callback, loadedFromFile)
{
throw new Error("Not implemented.");
+ },
+ /**
+ * @param {string} recordType
+ * @param {string=} title
+ * @return {!Element}
+ */
+ createEventDivider: function(recordType, title)
+ {
+ throw new Error("Not implemented.");
}
}
@@ -196,22 +213,6 @@ WebInspector.TimelineUIUtils.recordStyle = function(record)
}
/**
- * @param {!WebInspector.TimelineModel.Record} record
- * @return {boolean}
- */
-WebInspector.TimelineUIUtils.isEventDivider = function(record)
-{
- var recordTypes = WebInspector.TimelineModel.RecordType;
- if (record.type() === recordTypes.TimeStamp)
- return true;
- if (record.type() === recordTypes.MarkFirstPaint)
- return true;
- if (record.type() === recordTypes.MarkDOMContent || record.type() === recordTypes.MarkLoad)
- return record.data()["isMainFrame"];
- return false;
-}
-
-/**
* @param {string=} recordType
* @return {boolean}
*/
@@ -232,35 +233,6 @@ WebInspector.TimelineUIUtils.needsPreviewElement = function(recordType)
}
/**
- * @param {string} recordType
- * @param {string=} title
- * @return {!Element}
- */
-WebInspector.TimelineUIUtils.createEventDivider = function(recordType, title)
-{
- var eventDivider = document.createElement("div");
- eventDivider.className = "resources-event-divider";
- var recordTypes = WebInspector.TimelineModel.RecordType;
-
- if (recordType === recordTypes.MarkDOMContent)
- eventDivider.className += " resources-blue-divider";
- else if (recordType === recordTypes.MarkLoad)
- eventDivider.className += " resources-red-divider";
- else if (recordType === recordTypes.MarkFirstPaint)
- eventDivider.className += " resources-green-divider";
- else if (recordType === recordTypes.TimeStamp)
- eventDivider.className += " resources-orange-divider";
- else if (recordType === recordTypes.BeginFrame)
- eventDivider.className += " timeline-frame-divider";
-
- if (title)
- eventDivider.title = title;
-
- return eventDivider;
-}
-
-
-/**
* @param {!WebInspector.TimelineModel} model
* @param {!{name: string, tasks: !Array.<!{startTime: number, endTime: number}>, firstTaskIndex: number, lastTaskIndex: number}} info
* @return {!Element}
@@ -302,7 +274,7 @@ WebInspector.TimelineUIUtils.recordTitle = function(record, model)
return recordData["message"];
if (record.type() === WebInspector.TimelineModel.RecordType.JSFrame)
return recordData["functionName"];
- if (WebInspector.TimelineUIUtils.isEventDivider(record)) {
+ if (WebInspector.TimelineUIUtilsImpl.isEventDivider(record)) {
var startTime = Number.millisToString(record.startTime() - model.minimumRecordTime());
return WebInspector.UIString("%s at %s", WebInspector.TimelineUIUtils.recordStyle(record).title, startTime, true);
}
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698