Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 339443004: Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (Closed)

Created:
6 years, 6 months ago by yhirano
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@refactor-webmidi-initialization
Visibility:
Public.

Description

Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (https://codereview.chromium.org/311733004/) Reason for revert: This CL breaks the build. Original issue's description: > Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. > > Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer". > The initializer should stay alive until the initialization succeeds (i.e. the > associated Promise is resolved), the initialization fails > (i.e. rejected), or the associated ExecutionContext is stopped. > This CL introduces the the constructor mode ScriptPromiseResolverWithContext. > If KeepAliveWhilePending is specified, the created resolver stays alive while > one of the above conditions meets. > Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext. > > This CL rewrites WebMIDI and WebCrypto async operations with it. > > BUG=361041 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381 TBR=yhirano, haraken, eroman, toyoshim@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -216 lines) Patch
M Source/bindings/v8/ScriptPromiseResolverWithContext.h View 4 chunks +3 lines, -18 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverWithContext.cpp View 3 chunks +3 lines, -28 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.cpp View 3 chunks +138 lines, -58 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 3 chunks +15 lines, -11 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 3 chunks +34 lines, -14 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.h View 2 chunks +24 lines, -30 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.cpp View 2 chunks +97 lines, -52 lines 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yhirano
Created Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext.
6 years, 6 months ago (2014-06-18 03:19:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/339443004/1
6 years, 6 months ago (2014-06-18 03:20:00 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 03:20:01 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-18 03:20:02 UTC) #4
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 6 months ago (2014-06-18 03:22:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/339443004/1
6 years, 6 months ago (2014-06-18 03:23:01 UTC) #6
commit-bot: I haz the power
Change committed as 176383
6 years, 6 months ago (2014-06-18 03:23:31 UTC) #7
haraken
6 years, 6 months ago (2014-06-18 03:25:05 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698