Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Unified Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 339443004: Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@refactor-webmidi-initialization
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolverWithContext.cpp ('k') | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/crypto/CryptoResultImpl.h
diff --git a/Source/modules/crypto/CryptoResultImpl.h b/Source/modules/crypto/CryptoResultImpl.h
index 63a0193e001c53cc9a19ad67065fb7cb57ead704..c589ee196dad4cc8fbfed058ac5be90ef0b432ad 100644
--- a/Source/modules/crypto/CryptoResultImpl.h
+++ b/Source/modules/crypto/CryptoResultImpl.h
@@ -40,7 +40,6 @@
namespace WebCore {
-class ScriptPromiseResolverWithContext;
ExceptionCode webCryptoErrorToExceptionCode(blink::WebCryptoErrorType);
// Wrapper around a Promise to notify completion of the crypto operation.
@@ -52,7 +51,7 @@
// * The CryptoResult interface must only be called from the origin thread.
// * addref() and deref() can be called from any thread.
// * One of the completeWith***() functions must be called, or the
-// m_resolver will be leaked until the ExecutionContext is destroyed.
+// PromiseState will be leaked until the ExecutionContext is destroyed.
class CryptoResultImpl FINAL : public CryptoResult {
public:
~CryptoResultImpl();
@@ -72,7 +71,8 @@
private:
explicit CryptoResultImpl(ScriptState*);
- WeakPtr<ScriptPromiseResolverWithContext> m_resolver;
+ class PromiseState;
+ WeakPtr<PromiseState> m_promiseState;
};
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolverWithContext.cpp ('k') | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698