Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: media/base/audio_splicer.h

Issue 339433006: Don't crash on splice frame failure with bad content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/audio_splicer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_splicer.h
diff --git a/media/base/audio_splicer.h b/media/base/audio_splicer.h
index 389607ae2c2cc1046b6ba6ac79711a5b315907c5..0db5d08dd70b7c8e49b5bc0650b57f5d78edb51f 100644
--- a/media/base/audio_splicer.h
+++ b/media/base/audio_splicer.h
@@ -27,6 +27,12 @@ class MEDIA_EXPORT AudioSplicer {
enum {
// The number of ms to crossfade before trimming when buffers overlap.
kCrossfadeDurationInMilliseconds = 5,
+
+ // Largest gap or overlap allowed between buffers. Anything larger than
+ // this will trigger an error. This is an arbitrary value, but the initial
+ // selection of 50ms roughly represents the duration of 2 compressed AAC or
+ // MP3 frames.
+ kMaxTimeDeltaInMilliseconds = 50,
};
// Resets the splicer state by clearing the output buffers queue and resetting
« no previous file with comments | « no previous file | media/base/audio_splicer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698