Issue 3394012: Merge 59915 - Refcount the host content settings map from the content excepti...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3394012: Merge 59915 - Refcount the host content settings map from the content excepti... (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/branches/517/src/

Visibility:
Public.

Description

Merge 59915 - Refcount the host content settings map from the content exceptions table model. Otherwise, we run into a problem when the incognito profile goes away while the user is editing exceptions. BUG=51959 TEST=ContentExceptionsTableModelTest.* Review URL: http://codereview.chromium.org/3446013 TBR=jochen@chromium.org

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -8 lines)			Patch
M	chrome/browser/content_exceptions_table_model.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A +	chrome/browser/content_exceptions_table_model_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/host_content_settings_map.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/host_content_settings_map.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages