Issue 3446013: Refcount the host content settings map from the content exceptions table model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3446013: Refcount the host content settings map from the content exceptions table model. (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Visibility:
Public.

Description

Refcount the host content settings map from the content exceptions table model. Otherwise, we run into a problem when the incognito profile goes away while the user is editing exceptions. BUG=51959 TEST=ContentExceptionsTableModelTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59915

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -9 lines)			Patch
M	chrome/browser/content_exceptions_table_model.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
A	chrome/browser/content_exceptions_table_model_unittest.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	chrome/browser/host_content_settings_map.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/host_content_settings_map.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

10 years, 3 months ago (2010-09-20 07:48:59 UTC) #2

LGTM with a nit:

http://codereview.chromium.org/3446013/diff/1/3
File chrome/browser/content_exceptions_table_model.h (right):

http://codereview.chromium.org/3446013/diff/1/3#newcode61
chrome/browser/content_exceptions_table_model.h:61: return is_off_the_record ?
off_the_record_map_.get() : map_.get();
Nit: scoped_refptr<T> defines operator T*, so you could even leave the .get()
out if you wanted.

Expand Messages | Collapse Messages