Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339393005: [NaCl SDK] Add examples for bionic (Closed)

Created:
6 years, 6 months ago by noelallen1
Modified:
6 years, 5 months ago
Reviewers:
binji, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, scheib+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Currently, bionic only build a subset of the examples. This changes turns on all the examples and tests compiling those examples. BUG=344574 R=sbc@chromium.org, binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284165

Patch Set 1 #

Patch Set 2 : Add definition for MAX #

Total comments: 4

Patch Set 3 : Merge #

Patch Set 4 : Merge #

Patch Set 5 : Fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -28 lines) Patch
M native_client_sdk/src/build_tools/buildbot_run.py View 2 chunks +5 lines, -3 lines 0 comments Download
M native_client_sdk/src/examples/api/core/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/file_io/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/gamepad/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/graphics_3d/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/input_event/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/media_stream_audio/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/media_stream_video/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/mouse_cursor/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/mouse_lock/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/network_monitor/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/socket/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/url_loader/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/var_array_buffer/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/var_dictionary/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/websocket/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c View 1 2 3 4 2 chunks +12 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/jsoncpp/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/libjpeg/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp_private/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_gles2/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/sdk_util/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/zlib/library.dsc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
noelallen1
ptal
6 years, 6 months ago (2014-06-18 22:30:05 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/build_tools/buildbot_run.py File native_client_sdk/src/build_tools/buildbot_run.py (right): https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/build_tools/buildbot_run.py#newcode94 native_client_sdk/src/build_tools/buildbot_run.py:94: cmd.extend(['build_examples', 'copy_tests', 'build_tests']) Should this go in test_sdk ...
6 years, 6 months ago (2014-06-18 22:34:26 UTC) #2
binji
https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/build_tools/buildbot_run.py File native_client_sdk/src/build_tools/buildbot_run.py (right): https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/build_tools/buildbot_run.py#newcode94 native_client_sdk/src/build_tools/buildbot_run.py:94: cmd.extend(['build_examples', 'copy_tests', 'build_tests']) On 2014/06/18 22:34:26, Sam Clegg wrote: ...
6 years, 6 months ago (2014-06-18 22:37:17 UTC) #3
Sam Clegg
On 2014/06/18 22:37:17, binji wrote: > https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/build_tools/buildbot_run.py > File native_client_sdk/src/build_tools/buildbot_run.py (right): > > https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/build_tools/buildbot_run.py#newcode94 > ...
6 years, 6 months ago (2014-06-18 23:12:59 UTC) #4
noelallen1
https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c File native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c (right): https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c#newcode45 native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c:45: #define MAX(A, B) ((A) > (B) ? (A) : ...
6 years, 5 months ago (2014-07-17 17:10:54 UTC) #5
Sam Clegg
On 2014/07/17 17:10:54, noelallen1 wrote: > https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c > File native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c (right): > > https://codereview.chromium.org/339393005/diff/20001/native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c#newcode45 > ...
6 years, 5 months ago (2014-07-17 17:15:57 UTC) #6
noelallen1
A comment makes sense, but I'm not sure why I want to #ifdef for BIONIC. ...
6 years, 5 months ago (2014-07-17 17:29:52 UTC) #7
Sam Clegg
On 2014/07/17 17:29:52, noelallen1 wrote: > A comment makes sense, but I'm not sure why ...
6 years, 5 months ago (2014-07-17 17:33:01 UTC) #8
noelallen1
6 years, 5 months ago (2014-07-18 18:47:01 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 manually as r284165 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698