Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: native_client_sdk/src/build_tools/buildbot_run.py

Issue 339393005: [NaCl SDK] Add examples for bionic (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix warning Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/examples/api/core/example.dsc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/buildbot_run.py
diff --git a/native_client_sdk/src/build_tools/buildbot_run.py b/native_client_sdk/src/build_tools/buildbot_run.py
index c24c6df55614ee06039507f4c6d2b7022e0cdab7..374155d3f4baa7fe3331c704562f5aa16a4a070a 100755
--- a/native_client_sdk/src/build_tools/buildbot_run.py
+++ b/native_client_sdk/src/build_tools/buildbot_run.py
@@ -87,6 +87,11 @@ def StepTestSDK():
])
cmd.extend([sys.executable, 'test_sdk.py'])
+
+ # TODO(noelallen): crbug 386332
+ # For Bionic SDK, only build do a build test until we have hardware.
+ if 'bionic' in os.getenv('BUILDBOT_BUILDERNAME', ''):
+ cmd.extend(['build_examples', 'copy_tests', 'build_tests'])
Run(cmd, cwd=SCRIPT_DIR)
@@ -112,9 +117,6 @@ def main(args):
# to pass --build-only argument.
if os.getenv('BUILDBOT_BUILDERNAME', '').endswith('build'):
options.build_only = True
- # TODO(noelallen): Enable testing on bionic when we have an ARM solution.
- if 'bionic' in os.getenv('BUILDBOT_BUILDERNAME', ''):
- options.build_only = True
StepArmRunHooks()
StepRunUnittests()
« no previous file with comments | « no previous file | native_client_sdk/src/examples/api/core/example.dsc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698