Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 339343002: Remove the definition of AtomicOps_Internalx86CPUFeatures from base/atomicops_internals_tsan.h (Closed)

Created:
6 years, 6 months ago by Alexander Potapenko
Modified:
6 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, Jakob Kummerow
Project:
chromium
Visibility:
Public.

Description

Remove the definition of AtomicOps_Internalx86CPUFeatures from base/atomicops_internals_tsan.h As noted in https://codereview.chromium.org/10948035, this is not used by anyone in Chromium. BUG=None TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M base/atomicops_internals_tsan.h View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
TBR
6 years, 6 months ago (2014-06-18 09:43:26 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 6 months ago (2014-06-18 09:46:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/339343002/1
6 years, 6 months ago (2014-06-18 09:47:53 UTC) #3
commit-bot: I haz the power
Change committed as 278081
6 years, 6 months ago (2014-06-18 15:17:42 UTC) #4
Nico
lgtm, thanks! On Wed, Jun 18, 2014 at 8:17 AM, <commit-bot@chromium.org> wrote: > Change committed ...
6 years, 6 months ago (2014-06-18 18:30:21 UTC) #5
Nico
btw, the same file exists in v8, this should probably be done there too: https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/base/atomicops_internals_tsan.h&q=_tsan.h&sq=package:chromium&type=cs&l=9 ...
6 years, 6 months ago (2014-06-18 21:21:20 UTC) #6
Alexander Potapenko
6 years, 6 months ago (2014-06-19 08:24:10 UTC) #7
Message was sent while issue was closed.
+jkummerow
Jakob, may I kindly ask you to land a similar CL in V8? This is probably just a
matter of applying my patch to v8 trunk.
(IIRC V8 doesn't have a commit-queue so I anyway won't be able to land such a
patch myself)

Powered by Google App Engine
This is Rietveld 408576698